fix_: address pr comments

cmd/lint-panics/analyzer/analyzer.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"go/ast"
 	"os"
-	"time"
 
 	"go.uber.org/zap"
 
@@ -18,7 +17,7 @@ import (
 	"golang.org/x/tools/go/analysis/passes/inspect"
 	"golang.org/x/tools/go/ast/inspector"
 
-	gopls2 "github.com/status-im/status-go/cmd/lint-panics/gopls"
+	"github.com/status-im/status-go/cmd/lint-panics/gopls"
 	"github.com/status-im/status-go/cmd/lint-panics/utils"
 )
 
@@ -43,15 +42,17 @@ func New(ctx context.Context, logger *zap.Logger) (*analysis.Analyzer, error) {
 
 	logger.Info("creating analyzer", zap.String("root", cfg.RootDir))
 
-	gopls := gopls2.NewGoplsClient(ctx, logger, cfg.RootDir)
-	processor := newAnalyzer(logger, gopls, &cfg)
+	goplsClient := gopls.NewGoplsClient(ctx, logger, cfg.RootDir)
+	processor := newAnalyzer(logger, goplsClient, &cfg)
 
 	analyzer := &analysis.Analyzer{
 		Name:     "logpanics",
 		Doc:      fmt.Sprintf("reports missing defer call to %s", Pattern),
-		Run:      processor.Run,
 		Flags:    flags,
 		Requires: []*analysis.Analyzer{inspect.Analyzer},
+		Run: func(pass *analysis.Pass) (interface{}, error) {
+			return processor.Run(ctx, pass)
+		},
 	}
 
 	return analyzer, nil
@@ -65,21 +66,18 @@ func newAnalyzer(logger *zap.Logger, lsp LSP, cfg *Config) *Analyzer {
 	}
 }
 
-func (p *Analyzer) Run(pass *analysis.Pass) (interface{}, error) {
-	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)
-	defer cancel()
-
+func (p *Analyzer) Run(ctx context.Context, pass *analysis.Pass) (interface{}, error) {
 	inspected, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 	if !ok {
 		return nil, errors.New("analyzer is not type *inspector.Inspector")
 	}
 
-	// Check if the node is a GoStmt (which represents a 'go' statement)
+	// Create a nodes filter for goroutines (GoStmt represents a 'go' statement)
 	nodeFilter := []ast.Node{
 		(*ast.GoStmt)(nil),
 	}
 
-	// Traverse the AST to find goroutines
+	// Inspect go statements
 	inspected.Preorder(nodeFilter, func(n ast.Node) {
 		p.ProcessNode(ctx, pass, n)
 	})

cmd/lint-panics/analyzer/config.go

@@ -32,7 +32,13 @@ func (c *Config) ParseFlags() (flag.FlagSet, error) {
 	// We parse the flags here to have `rootDir` before the call to `singlechecker.Main(analyzer)`
 	// For same reasons we discard the output and skip the undefined flag error.
 	err := flags.Parse(os.Args[1:])
-	if err != nil && strings.Contains(err.Error(), "flag provided but not defined") {
+	if err == nil {
+		return *flags, nil
+	}
+
+	if strings.Contains(err.Error(), "flag provided but not defined") {
+		err = nil
+	} else if strings.Contains(err.Error(), "help requested") {
 		err = nil
 	}
 

cmd/lint-panics/gopls/gopls.go

@@ -55,7 +55,7 @@ func NewGoplsClient(ctx context.Context, logger *zap.Logger, rootDir string) *Co
 		panic(err)
 	}
 
-	stream := jsonrpc2.NewStream(&CombinedReadWriteCloser{
+	stream := jsonrpc2.NewStream(&IOStream{
 		stdin:  stdin,
 		stdout: stdout,
 	})

cmd/lint-panics/gopls/stream.go

@@ -2,24 +2,24 @@ package gopls
 
 import "io"
 
-// CombinedReadWriteCloser combines stdin and stdout into one interface.
-type CombinedReadWriteCloser struct {
+// IOStream combines stdin and stdout into one interface.
+type IOStream struct {
 	stdin  io.WriteCloser
 	stdout io.ReadCloser
 }
 
 // Write writes data to stdin.
-func (c *CombinedReadWriteCloser) Write(p []byte) (n int, err error) {
+func (c *IOStream) Write(p []byte) (n int, err error) {
 	return c.stdin.Write(p)
 }
 
 // Read reads data from stdout.
-func (c *CombinedReadWriteCloser) Read(p []byte) (n int, err error) {
+func (c *IOStream) Read(p []byte) (n int, err error) {
 	return c.stdout.Read(p)
 }
 
 // Close closes both stdin and stdout.
-func (c *CombinedReadWriteCloser) Close() error {
+func (c *IOStream) Close() error {
 	err1 := c.stdin.Close()
 	err2 := c.stdout.Close()
 	if err1 != nil {

healthmanager/blockchain_health_manager.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"sync"
 
-	gocommon "github.com/status-im/status-go/common"
+	status_common "github.com/status-im/status-go/common"
 	"github.com/status-im/status-go/healthmanager/aggregator"
 	"github.com/status-im/status-go/healthmanager/rpcstatus"
 )
@@ -73,7 +73,7 @@ func (b *BlockchainHealthManager) RegisterProvidersHealthManager(ctx context.Con
 	statusCh := phm.Subscribe()
 	b.wg.Add(1)
 	go func(phm *ProvidersHealthManager, statusCh chan struct{}, providerCtx context.Context) {
-		defer gocommon.LogOnPanic()
+		defer status_common.LogOnPanic()
 		defer func() {
 			phm.Unsubscribe(statusCh)
 			b.wg.Done()

services/wallet/api.go

@@ -18,7 +18,7 @@ import (
 	signercore "github.com/ethereum/go-ethereum/signer/core/apitypes"
 	abi_spec "github.com/status-im/status-go/abi-spec"
 	"github.com/status-im/status-go/account"
-	common2 "github.com/status-im/status-go/common"
+	status_common "github.com/status-im/status-go/common"
 	statusErrors "github.com/status-im/status-go/errors"
 	"github.com/status-im/status-go/eth-node/crypto"
 	"github.com/status-im/status-go/eth-node/types"
@@ -780,7 +780,7 @@ func (api *API) BuildTransactionsFromRoute(ctx context.Context, buildInputParams
 	log.Debug("[WalletAPI::BuildTransactionsFromRoute] builds transactions from the generated best route", "uuid", buildInputParams.Uuid)
 
 	go func() {
-		defer common2.LogOnPanic()
+		defer status_common.LogOnPanic()
 		api.router.StopSuggestedRoutesAsyncCalculation()
 
 		var err error
@@ -843,7 +843,7 @@ func (api *API) ProceedWithTransactionsSignatures(ctx context.Context, signature
 func (api *API) SendRouterTransactionsWithSignatures(ctx context.Context, sendInputParams *requests.RouterSendTransactionsParams) {
 	log.Debug("[WalletAPI:: SendRouterTransactionsWithSignatures] sign with signatures and send")
 	go func() {
-		defer common2.LogOnPanic()
+		defer status_common.LogOnPanic()
 
 		var (
 			err              error
@@ -930,7 +930,7 @@ func (api *API) SendRouterTransactionsWithSignatures(ctx context.Context, sendIn
 			chainIDs = append(chainIDs, tx.FromChain)
 			addresses = append(addresses, common.Address(tx.FromAddress))
 			go func(chainId uint64, txHash common.Hash) {
-				defer common2.LogOnPanic()
+				defer status_common.LogOnPanic()
 				err = api.s.transactionManager.WatchTransaction(context.Background(), chainId, txHash)
 				if err != nil {
 					return