Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Add network preferences" functionality in Save address flow #16995

Closed
6 tasks
Tracked by #18568
briansztamfater opened this issue Aug 11, 2023 · 2 comments · Fixed by #20364
Closed
6 tasks
Tracked by #18568

Implement "Add network preferences" functionality in Save address flow #16995

briansztamfater opened this issue Aug 11, 2023 · 2 comments · Fixed by #20364
Assignees
Labels
feature feature requests wallet: Save Address All issues related to save address feature wallet: Settings All issues for the mobile wallet settings
Milestone

Comments

@briansztamfater
Copy link
Member

briansztamfater commented Aug 11, 2023

Feature Issue

User Story

As a user, I want to be able to set network preferences so that transaction network choices are automatically optimized based on my saved preferences for efficient calculations.

Description

On tap of the preferences icon next to the address, the network preferences sheet should be shown and the user should be allowed to select any network of choice for that address

NOTE: The network preference selection is not allowed if the address is added from ENS.

Design

Link to Figma

Acceptance Criteria

  • In the Save address bottom sheet, when user taps on preferences icon at the right of the address card, Add network preferences bottom sheet should be shown.
  • "Add preferences" button at the bottom should start in a disabled state.
  • User can enable and disable Mainnet, Optimism and Arbitrum networks.
  • When user toggles a network, address suffix should reflect network preferences (eth: in blue if mainnet is enabled, opt: in red if Optimism is enabled, arb: in turquoise if Arbitrum is enabled).
  • When preferences are modified, "Add preferences" button at the bottom should be enabled.
  • When "Add preferences" button at the bottom is tapped, Add network preferences bottom sheet should be dismissed, preferences should be updated and reflected in Save address bottom sheet
@J-Son89
Copy link
Contributor

J-Son89 commented Oct 20, 2023

related to this @briansztamfater - I created an issue just to implement the ui side of this -#17699 but we will need to hook it up properly to save address page etc 👍

@OmarBasem
Copy link
Contributor

Hey @shivekkhurana, are you working on this issue? I see you linked it in a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests wallet: Save Address All issues related to save address feature wallet: Settings All issues for the mobile wallet settings
Projects
Archived in project
4 participants