feat(wallet): Add network preferences for saved address #20364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (21)
|
smohamedjavid
force-pushed
the
feature/network-preferences-for-saved-address
branch
7 times, most recently
from
7dcc8f9
to
246d383
Compare
smohamedjavid
commented
Jun 5, 2024
There was a problem hiding this comment.
Just moved this namespace out of sheets as this is a separate screen 👍
mohsen-ghafouri
approved these changes
Jun 6, 2024
Comment on lines
74
to
75
| [address selected-networks address-label | ||
| address-color])] |
There was a problem hiding this comment.
Nice work, just a question, why not?
Suggested change
| [address selected-networks address-label | |
| address-color])] | |
| [address-without-prefix chain-short-names address-label | |
| address-color])] |
There was a problem hiding this comment.
Ah, we can. I added the address as if there is any change, it will affect the address-without-prefix as well.
Same for selected-networks. I will update it 👍
smohamedjavid
commented
Jun 6, 2024
| @@ -35,7 +35,7 @@ | |||
| :blur? true | |||
| :action :arrow} | |||
| {:title (i18n/label :t/wallet) | |||
| :on-press #(rf/dispatch [:navigate-to-within-stack [:screen/settings.wallet :screen/settings]]) | |||
| :on-press #(rf/dispatch [:navigate-to-within-stack [:screen/settings.wallet :settings]]) | |||
There was a problem hiding this comment.
The settings screen wasn't using the :screen/ qualifier 🤦. Fixed in this PR. 6a2bb51
smohamedjavid
force-pushed
the
feature/network-preferences-for-saved-address
branch
from
6a2bb51
to
e45715b
Compare
86% of end-end tests have passedNot executed tests (1)Failed tests (4)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestWalletMultipleDevice:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
|
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
smohamedjavid
force-pushed
the
feature/network-preferences-for-saved-address
branch
from
e45715b
to
1068d33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16995
Summary
This PR:
saved-address-network-preferences.mp4
Testing notes
Testing will be done once Saved Address epic is done
Platforms
status: ready