💾 Save address in send flow #19553
Closed
💾 Save address in send flow #19553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set default networks from address saved in the db
Jenkins BuildsClick to see older builds (36)
|
…nt-to-be-reusable
shivekkhurana
changed the title
- Revert `some` to `contains`
…nt-to-be-reusable
|
This PR will be gutted and implemented by the Wallet Settings Crew. I'll always be available for help and support.
|
shivekkhurana
deleted the
19546-enhance-network-preferences-component-to-be-reusable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19546
fixes #16994
fixes #16995
Summary
This PR almost completes the saved address from send flow epic. There is one missing piece where we need to handle saving ENS names instead of HEX addresses.
There are two major aspects that need to be tested:
2.1 The sub flow of saving the address on different networks.
Review notes
This PR is heavy from QA perspective. So I have hidden the entry point to the save address feature.
The idea is that we get this merged. Then extract the
network-preferencescomponent and make it pure. Right now it can be pure or impure.And when the network preferences is merged, we enable this feature in a separate PR.
--
The other option is that the QA team prioritises this and gets it tested. So we merged it, and then work on purification of the
network-preferencescomponent. I'll talk to the team and update this comment accordingly.Testing notes
Platforms
Areas that maybe impacted
Functional
Steps to test
First Flow (Recipient address is not saved)
Second flow (Recipient address is saved already)
status: ready