Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dot/comma is shown on keyboard when requesting/sending funds #2681

Closed
asemiankevich opened this issue Dec 11, 2017 · 20 comments · Fixed by #10393
Closed

No dot/comma is shown on keyboard when requesting/sending funds #2681

asemiankevich opened this issue Dec 11, 2017 · 20 comments · Fixed by #10393

Comments

@asemiankevich
Copy link
Contributor

asemiankevich commented Dec 11, 2017

Description

Type: Bug

Summary: No dot/comma displayed on keyboard, so can't request or send decimal amount

Expected behavior

image

Actual behavior

image

Reproduction

  • Open Status
  • Go to Wallet
  • Click Request
  • Observe keyboard shown

Additional Information

  • Status version: 0.9.10-433-g25ec3602+ (1990)
  • Operating System: Android

Logs

TF: https://app.testfairy.com/projects/4803622-status/builds/7246163/sessions/4/?accessToken=XMMInuMJvGuHON--jIcXYCQ56uc

@yenda
Copy link
Contributor

yenda commented Dec 11, 2017

Reminder for me : facebook/react-native#12988

@jeluard jeluard added the wallet label Dec 11, 2017
@yenda yenda self-assigned this Dec 11, 2017
@yenda
Copy link
Contributor

yenda commented Dec 11, 2017

Fixed in the branch

@asemiankevich
Copy link
Contributor Author

Fixed in branch 0.9.10-438-g6948dd17+

@yenda
Copy link
Contributor

yenda commented Jan 18, 2018

@asemiankevich can you list the devices that encounter this issue as well as the language in which it happens, this is important for this issue. For a device on which the bug is present please try with english US and french or russian

@yenda
Copy link
Contributor

yenda commented Apr 13, 2018

@asemiankevich is it still happening ?

@asemiankevich
Copy link
Contributor Author

@yenda yes, it was in place some time ago (couple of weeks) , however i do not own the device now so cant say for sure. @yevh-berdnyk Zhenya, could you please check it?

@denis-sharypin
Copy link

denis-sharypin commented Apr 17, 2018

@yenda Maybe if we specify a KeyboardType to Numeric it will work properly?
screenshot 2018-04-17 16 30 06

@Serhy
Copy link
Contributor

Serhy commented Apr 17, 2018

I can confirm the issue is still present on Samsung Galaxy Note 4 (with Android 6.0.1).
Tried with English (us), English (uk), French, Russian as @yenda suggested - in all cases, there is no delimiter button on Wallet screen for numeric keyboard:
screenshot_2018-04-17-17-13-04

@yevh-berdnyk
Copy link
Contributor

LG V20, Android 7.0 - without delimiter
2018-04-17 18 07 11

@asemiankevich asemiankevich changed the title No dot/comma is shown on keyboard when requesting/sending funds [2217] No dot/comma is shown on keyboard when requesting/sending funds Apr 26, 2018
@Roger--Han
Copy link

we fix this issue by adding inline js autocapitalize="off" to the input field, <input type="number" autocapitalize="off">, if this still cannot help you have to set the type to "tel" and only allow user to type 1234567890 and .

@Serhy
Copy link
Contributor

Serhy commented Jun 18, 2018

I've noticed one thing: in Dapp (Oasis Direct) on the affected device (Galaxy Note 4) numeric fields request numeric keyboard with a dot as separator.
So in Wallet it (still) looks like:
screenshot_2018-04-17-17-13-04

And this is the same device and OS but in Oasis Direct:

screenshot_2018-06-18-17-44-49

@goranjovic what's the diference between two: requesting numeric keyboard in numeric field in Wallet (e.g. Send -> Specify amount) and numberic keyboard requested from Dapp (Oasis Direct)?

@asemiankevich asemiankevich removed this from the 0.9.13 milestone Aug 31, 2018
@ghost
Copy link

ghost commented Nov 29, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale label Nov 29, 2018
@ghost
Copy link

ghost commented Dec 6, 2018

This issue has been automatically closed. Please re-open if this issue is important to you.

@ghost ghost closed this as completed Dec 6, 2018
@asemiankevich asemiankevich reopened this Dec 6, 2018
@ghost ghost removed the stale label Dec 6, 2018
@mandrigin
Copy link
Contributor

@goranjovic @asemiankevich maybe we can make a bounty out of this bug instead?

@phillbaker
Copy link

It seems like this should have been solved with decimal-pad support on android: facebook/react-native#19714, however, I was not able to get decimal-pad to work on a physical LG Stylo 3 (Android 7.0) - there was no difference between decimal-pad and numeric.

However, phone-pad does give access to a decimal, so that seems like a decent workaround.

@AnnuRArya
Copy link

Anyone fixed the issue on Samsung ? I have set to Editext in Xamarin.Android

android:inputType="numberDecimal"
android:capitalize="none"

and in Dutch the keyboard still shows '.' and no ','

@churik
Copy link
Member

churik commented Feb 24, 2020

@Serhy would you mind to recheck it when you have time?
I can't start app on Android 6 in BrowserStack, it is crashed

@Serhy
Copy link
Contributor

Serhy commented Feb 26, 2020

Yes, it's still present in Release 1.0.1 build:

Screenshot 2020-02-26 at 17 30 02

@richard-ramos
Copy link
Member

@churik, @Serhy
Is this still an issue? Currently that input field is set as "numeric" as seen on this line https://github.com/status-im/status-react/blob/37028c62a2433067122be126db1183ec4addc487/src/status_im/ui/screens/wallet/send/views.cljs#L104 which according to this guide https://lefkowitz.me/visual-guide-to-react-native-textinput-keyboardtype-options/ should display the keyboard

On my phone and simulator it displays the dot/comma
Screenshot_20200420-162531_Status
Screenshot from 2020-04-20 16-22-38

@Serhy
Copy link
Contributor

Serhy commented Apr 21, 2020

@richard-ramos yes, it's still an issue (same like in on real #2681 (comment))
I see it on real device Samsung Galaxy Note 4 with Android 6.0.1

Here is the video of numeric keyboard view in Status and in Chrome(used Airswap dapp):
https://drive.google.com/file/d/1X1e7-JR7TT9mWqoNqVhWDwA6WZt5kSr6/view?usp=sharing

Here is keyboard_galaxy_note_4_in_status.txt for when I tap Send button in Status (so keyboard without delimeter appears) and logs keyboard_galaxy_note_4_chrome-brows.txt for when I tap in input of Dapp to call numeric keyboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment