-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react native 0.50.3 #2217
Conversation
@@ -73,7 +74,7 @@ public boolean getUseDeveloperSupport() { | |||
new ReactNativeDialogsPackage(), | |||
new ImageResizerPackage(), | |||
new PickerPackage(), | |||
new WebViewBridgePackage(BuildConfig.DEBUG, callRPC), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely need to pass callRPC
to WebViewBridgePackage
@yenda What's the state of this PR? |
1c2df27
to
53a998e
Compare
9642373
to
d97c171
Compare
@@ -43,6 +43,7 @@ | |||
81C6E6AE0AA739BE9D87C1D0 /* libPods-StatusImTests.a in Frameworks */ = {isa = PBXBuildFile; fileRef = FC1CBCFE6C906043D6CCEEE1 /* libPods-StatusImTests.a */; }; | |||
82E689BAF9FB43C8AC6FF1CA /* EvilIcons.ttf in Resources */ = {isa = PBXBuildFile; fileRef = CEB0E2659D1A4F5FA842057A /* EvilIcons.ttf */; }; | |||
832341BD1AAA6AB300B99B32 /* libRCTText.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 832341B51AAA6A8300B99B32 /* libRCTText.a */; }; | |||
<<<<<<< ours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts shouldn't be committed
Please specify version of RN we are upgrading to; when issue was created latest stable was 0.47, now it is 0.50. Is this the one we use? |
Relevant issue for iOS upgrade and unable to open Xcode: facebook/react-native#12261 |
So for all I know it could take a week. It might also take an hour if you find the right combination. One idea is to start RN upgrade from scratch on iOS side, don't use the magic git upgrade script, and then merge that upgrade with this one. We could also put up a bounty to get some Xcode ninjas to resolve this. |
4f4d8fb
to
89c793d
Compare
The last status - except for changes here, one needs to change the import in header files of the |
@janherich can you fork the libs until they are fixed upstream because node_modules is local. We might want to do this for all libs anyway |
package.json
Outdated
@@ -29,7 +29,7 @@ | |||
"homoglyph-finder": "1.1.1", | |||
"https-browserify": "0.0.1", | |||
"identicon.js": "github:status-im/identicon.js", | |||
"instabug-reactnative": "git+https://github.com/status-im/instabug-reactnative.git", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come you don't update the status-im one? We should use that, not our own forks.
If it is a permission issue and you do this to be unblocked: OK - please ping Carl and/or Nabil and he will sort you (us) out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json
Outdated
@@ -29,7 +29,7 @@ | |||
"homoglyph-finder": "1.1.1", | |||
"https-browserify": "0.0.1", | |||
"identicon.js": "github:status-im/identicon.js", | |||
"instabug-reactnative": "git+https://github.com/status-im/instabug-reactnative.git", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json
Outdated
@@ -55,7 +55,7 @@ | |||
"react-native-fcm": "10.0.3", | |||
"react-native-fs": "2.8.1", | |||
"react-native-http": "github:tradle/react-native-http#834492d", | |||
"react-native-http-bridge": "github:yenda/react-native-http-bridge", | |||
"react-native-http-bridge": "github:janherich/react-native-http-bridge", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hot potato :D
package.json
Outdated
"https-browserify": "0.0.1", | ||
"identicon.js": "github:status-im/identicon.js", | ||
"instabug-reactnative": "git+https://github.com/status-im/instabug-reactnative.git", | ||
"nfc-react-native": "github:status-im/nfc-react-native", | ||
"instabug-reactnative": "git+https://github.com/janherich/instabug-reactnative.git", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment appeared as outdated, not sure why. 54f5bcb#r152777933
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is due to permission issues, ping Carl and Nabil in slack on this
912ad65
to
b2133fb
Compare
@yenda everything works on iOS side (including |
4b356c0
to
e0c86ae
Compare
c838456
to
25ec360
Compare
Branch: status-im:update-react-native |
|
25ec360
to
a62c1a7
Compare
505d287
to
ec74efe
Compare
All issues above are fixed in branch below. No new issues found. I assume we can merge this.Branch: status-im:update-react-native |
8e66045
to
bf73951
Compare
a76727b
to
f222940
Compare
[#bug] fix realm version
f222940
to
f472881
Compare
fixes #1690
Test:
This changes react-native version and update most libraries in the process. But there is no changes to our code itself so if the app loads, tabs work, scrolling work, drawer works it should be good.
status: ready