-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump go to 1.20 and update patches #18564
Conversation
Jenkins BuildsClick to see older builds (28)
|
iOS builds fail with :
The |
a0f0ddc
to
d263519
Compare
8c3ae7f
to
d921ec8
Compare
same issue in go 1.20 repo -> golang/go#58416 |
9bae038
to
06a7c7b
Compare
83% of end-end tests have passed
Failed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Expected to fail tests (5)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (40)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
|
06a7c7b
to
03cf4ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about nix, but i ran your PR locally and LGTM! Thank you for the upgrade! 💥 @siddarthkay
@qfrank : Thanks for testing the PR locally 👍🏻 |
fec5aa6
to
a018878
Compare
@siddarthkay update on this issue: I checked on several other PRs and nightly to make sure that the issue is only here. But @mariia-skrypnyk still found another PR where this is also reproduced #18468. |
Thanks for the update, will hold on investigating this till I hear more next week :) |
Hey @siddarthkay, we double-checked this issue on several PRs (multiple times) and it still looks like this PR's issue 😬 In |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
abb9a83
to
e4e213b
Compare
e4e213b
to
f71dd92
Compare
71% of end-end tests have passed
Failed tests (12)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (2)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Passed tests (34)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
@siddarthkay new update on Issue 1: the Waku team is working on the fix for the db (it's down now), let's check how it works in your PR after the fix. UPD: Checked the fix and it does not fix the issue in this PR :( |
Hi @qoqobolo : Thanks for checking 🙏🏻 |
@siddarthkay could you rebase this PR, please? |
Hi @qoqobolo : the golang side is broke, so I'll move this PR to draft now. |
@siddarthkay okay, thanks! |
closing in favour of : #19564 |
Summary
This PR
golang
version to1.20
gomobile
to a newer commitgomobile
to build because of this issue : x/mobile/bind/java: fatal error: jni.h: No such file or directory golang/go#58426SWIFT_VERSION
flag forproject.pbxproj
to5.2
PRESERVE_DEAD_CODE_INITS_AND_TERMS
flag fromproject.pbxproj
golang
bump,gowaku
upgrade andlibp2p
upgrade done in status-go here -> chore: bump go-libp2p, go-waku and golang status-go#4601Testing Notes
Please test everything since
golang
has been upgraded onstatus-go
side.go-waku
andlibp2p
has also been upgraded onstatus-go
side.status: ready