upgrade go to 1.20 #19564
Merged
upgrade go to 1.20 #19564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Jenkins BuildsClick to see older builds (64)
|
83% of end-end tests have passedFailed tests (8)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (43)Click to expandClass TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
siddarthkay
force-pushed
the
upgrade/go-1.20
branch
2 times, most recently
from
aa38572
to
f9a8bd3
Compare
siddarthkay
force-pushed
the
upgrade/go-1.20
branch
from
f9a8bd3
to
befb27f
Compare
siddarthkay
force-pushed
the
upgrade/go-1.20
branch
from
befb27f
to
0f318b3
Compare
77% of end-end tests have passedFailed tests (11)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (40)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
|
siddarthkay
force-pushed
the
upgrade/go-1.20
branch
from
0f318b3
to
f632643
Compare
|
Hi @siddarthkay thank you for PR. Take a look at a found issue PR_ISSUE 1: Community is not fetchedSteps:
Actual result:Community is not fetched communitynotfetched.mp4Expected result:Community is fetched OS:IOS, Android Logs |
98% of end-end tests have passedExpected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (51)Click to expandClass TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
|
|
hi @siddarthkay thank you for the fixes. PR is ready to be merged |
siddarthkay
force-pushed
the
upgrade/go-1.20
branch
11 times, most recently
from
4f51cb2
to
9a9869e
Compare
siddarthkay
pushed a commit
to status-im/status-go
that referenced
this pull request
Apr 18, 2024
This commit attempts to upgrade go version to 1.20.12 This commit also removes the following items from lint checks : * `goconst` * `structcheck` * `deadcode` * `golint` * `varcheck` Mobile PR for QA purposes -> status-im/status-mobile#19564
siddarthkay
pushed a commit
to status-im/status-go
that referenced
this pull request
Apr 18, 2024
This commit attempts to upgrade go version to 1.20.12 This commit also removes the following items from lint checks : * `goconst` * `structcheck` * `deadcode` * `golint` * `varcheck` Mobile PR for QA purposes -> status-im/status-mobile#19564
siddarthkay
added a commit
to status-im/status-go
that referenced
this pull request
Apr 18, 2024
This commit attempts to upgrade go version to 1.20.12 This commit also removes the following items from lint checks : * `goconst` * `structcheck` * `deadcode` * `golint` * `varcheck` Mobile PR for QA purposes -> status-im/status-mobile#19564
siddarthkay
force-pushed
the
upgrade/go-1.20
branch
2 times, most recently
from
e9e390e
to
0610793
Compare
status-im/status-go@a39c01d...5e9f961 ## Summary This commit also points to status-go branch where we have upgraded go to 1.20 Related statusgo PR -> status-im/status-go#5027 ### Testing notes Please test everything, specially the store node stuff. #### Platforms - Android - iOS status: ready
siddarthkay
force-pushed
the
upgrade/go-1.20
branch
from
0610793
to
484f2a2
Compare
jakubgs
reviewed
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR also points to status-go branch where we have upgraded go to 1.20
Related statusgo PR -> status-im/status-go#5027
Testing notes
Please test everything, specially the store node stuff.
Platforms
status: ready