Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/fmodf #3059

Merged
merged 10 commits into from
Nov 10, 2024
Merged

Conversation

gunjjoshi
Copy link
Member

Resolves a part of #649.

Description

What is the purpose of this pull request?

This pull request:

float stdlib_base_fmodf( const float x, const float y )

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Code Coverage report:

Screenshot 2024-11-03 at 23 08 23

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 3, 2024
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Nov 9, 2024
@Planeshifter Planeshifter self-requested a review November 9, 2024 21:25
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @gunjjoshi!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Nov 10, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `math/base/special/fmodf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3059
Ref: https://github.com/stdlib-js/stdlib/issues/2997
Ref: https://github.com/stdlib-js/stdlib/issues/3055
Ref: https://github.com/stdlib-js/stdlib/issues/649

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 7fd112c into stdlib-js:develop Nov 10, 2024
17 of 18 checks passed
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
PR-URL: stdlib-js#3059
Ref: stdlib-js#2997
Ref: stdlib-js#3055
Ref: stdlib-js#649

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@gunjjoshi gunjjoshi deleted the fmodf branch November 16, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants