Fix decoding nil pointer into a previously used object #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
changed the title
abuiles
approved these changes
Oct 27, 2020
tamirms
approved these changes
Oct 27, 2020
bartekn
added a commit
to stellar/go
that referenced
this pull request
Oct 28, 2020
Upgrade `go-xdr` to the latest version. The new version fixes two bugs in `Decoder`: stellar/go-xdr#13 stellar/go-xdr#14
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in
Decoder.decodePtr. When decoding a struct with a pointer field into previously used object (ex. in a loop with object created outside of the loop) the previous non-nilpointer value was not overwritten if the new value wasnil. SeeTestDecodeNilPointerIntoExistingObjectWithNotNilPointerfor more context.