Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizon/ingest: refactor initial load of orderbook offers/pools to use functional streaming #4155

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Jan 1, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

at init time, entire orderbook was loaded into intermediate ram(slice) first from db resultset, then the slice was copied piece by piece into the orderbook memory, doubling the overall ram size needed by orderbook state for some initial amount of time.

Why

performance improvement to load orderbook data more efficiently at startup, avoid the double ram usage, handle larger sizes as things scale up

Closes #1622

Known limitations

does not change final orderbook state, it is still stored in ram

@sreuland sreuland requested a review from a team January 3, 2022 15:33
@sreuland sreuland merged commit b784365 into stellar:master Jan 4, 2022
liquidityPool := LiquidityPool{}

for rows.Next() {
if err = rows.StructScan(&liquidityPool); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember one issue in our XDR decoder: an object reused for decoding was not cleared so sometimes pointer fields contained the old data. I think this can be also the case here. Can we check? The fix would be to move liquidityPool variable inside the for loop.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the PRs for reference: stellar/go-xdr#13 stellar/go-xdr#14.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, every field in the struct is set to a column value in results(selected from liquidity_pools table) per row iteration during StructScan, so, shouldn't need init between iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize Orderbook loading to use sql rows stream directly
3 participants