Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo version pinning improvements #1222

Closed
3 of 6 tasks
graydon opened this issue Nov 16, 2023 · 4 comments
Closed
3 of 6 tasks

Cargo version pinning improvements #1222

graydon opened this issue Nov 16, 2023 · 4 comments
Assignees
@graydon
Labels
bug Something isn't working

Comments

@graydon
Copy link
Contributor

graydon commented Nov 16, 2023 •
edited
Loading

We're still not aggressive enough about making Cargo not change stuff underfoot. Plan:

  • pass --locked to all cargo commands in every place we do anything in CI
  • set all Cargo.toml version specs of our own to = constraints
  • add a make update-deps target that does cargo +nightly -Z minimal-dependencies update or so
  • enable cackle and cargo-deny on core
  • update core's and env's deps using the same make update-deps and carefully compare solutions match
  • check that core and env both use cargo resolver v2
@graydon graydon added the bug Something isn't working label Nov 16, 2023
@graydon graydon self-assigned this Nov 20, 2023
@graydon
Copy link
Contributor Author

graydon commented Nov 20, 2023

Not going to do all of this -- we'll do the parts that represent "locking what we've got" (steps 1, 2 and 4) but not adopt minimal-deps or change resolver or anything like that.

@leighmcculloch
Copy link
Member

Why won't we change the resolver? It's a one line change.

@graydon
Copy link
Contributor Author

graydon commented Nov 21, 2023

Because it'd be weird / misleading to say we're on resolver 2 but not re-resolve with it, and the point here is to not change any more deps at this point.

This was referenced Nov 28, 2023
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 28, 2023
@graydon
Cargo version pinning (#1255)
b357bda 
This does the env side of #1222 -- there are still core-side things to
do but this is a step.

No packages are changed in the main lockfile here, just the one in the
fuzzer sub-workspace which was out of sync.
@graydon
Copy link
Contributor Author

graydon commented Nov 30, 2023

Done all we're going to do here as of stellar/stellar-core#4061 and #1257

@graydon graydon closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graydon graydon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @leighmcculloch