Cargo version pinning #1255
Merged
Cargo version pinning #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Nov 28, 2023
|
Transitive deps get pinned in the trees baked into core in the core build. We don't have anything doing that at the plain env layer. It might be nice, but the core build is the level that's most worried about minor deviation. I don't know if locking is necessary for publishing, that's an interesting question. I assumed not. It looks like maybe it does support --locked also. I guess I will open another PR with that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the env side of #1222 -- there are still core-side things to do but this is a step.
No packages are changed in the main lockfile here, just the one in the fuzzer sub-workspace which was out of sync.