Code review, cleanup, removal of dead/dangerous host functions #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Sep 23, 2023
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
Sep 25, 2023
This just adapts to the following env changes: - stellar/rs-soroban-env#1080 - stellar/rs-soroban-env#1081 - stellar/rs-soroban-env#1082 - stellar/rs-soroban-env#1083 - stellar/rs-soroban-env#1079 - stellar/rs-soroban-env#1085 As well as XDR changes: - stellar/rs-stellar-xdr#303 - stellar/rs-stellar-xdr#304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is fairly trivial cleanup except the part where I'm removing 2 host functions:
These are vestigial from the older auth scheme and are potential footguns to leave exposed; the consensus seems to be that anything you should do with them you can do better with the new auth system, so exposing them is just asking for trouble.