Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review, cleanup, removal of dead/dangerous host functions #1085

Merged
merged 14 commits into from
Sep 23, 2023
Merged

Code review, cleanup, removal of dead/dangerous host functions #1085

merged 14 commits into from
Sep 23, 2023

Commits on Sep 23, 2023

  1. Mark many unused vmcaller args as _vmcaller

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    eb737e8 View commit details
    Browse the repository at this point in the history

  2. Make guest::require private

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    627114f View commit details
    Browse the repository at this point in the history

  3. Add missing metering

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    313de92 View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    8101eec View commit details
    Browse the repository at this point in the history

  5. Remove superfluous 'move' closure qualifiers

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    85f8a21 View commit details
    Browse the repository at this point in the history

  6. Improve comments

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    bc97266 View commit details
    Browse the repository at this point in the history

  7. Add some FIXMEs and links to existing issues.

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    7fe3eee View commit details
    Browse the repository at this point in the history

  8. Make missing vmcaller contexts an internal error.

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    c490655 View commit details
    Browse the repository at this point in the history

  9. Improve a couple error message strings.

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    02e5a76 View commit details
    Browse the repository at this point in the history

  10. Do an redundant early index validity check, for symmetry.

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    8e95e94 View commit details
    Browse the repository at this point in the history

  11. Avoid degrading an error.

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    a4eaa09 View commit details
    Browse the repository at this point in the history

  12. Avoid allocating an object when timestamps are small.

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    a29df22 View commit details
    Browse the repository at this point in the history

  13. Remove dead and dangerous Env::{get_invoking_contract,get_current_cal… 

    …l_stack}
    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    010dc7e View commit details
    Browse the repository at this point in the history

  14. Regenerate wasms

    @graydon
    graydon committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    3fbe2b8 View commit details
    Browse the repository at this point in the history