Ported the implementation of binary search from Rust <=1.81 to Soroban #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n env. This is necessary for 2 reasons: - Fix the immediate issue of CI failing due to observation divergence in Rust 1.82 caused by the binary search implementation change - Protect ourselves from the similar issues in the future - we were effectively observing the stdlib implementation and that's incorrect and risky in the long term.
graydon
approved these changes
Oct 21, 2024
graydon
approved these changes
Oct 21, 2024
dmkozh
added a commit
that referenced
this pull request
Oct 24, 2024
#1477) ### What Ported the implementation of binary search from Rust <=1.81 to Soroban env. ### Why This is necessary for 2 reasons: - Fix the immediate issue of CI failing due to observation divergence in Rust 1.82 caused by the binary search implementation change - Protect ourselves from the similar issues in the future - we were effectively observing the stdlib implementation and that's incorrect and risky in the long term. ### Known limitations N/A
graydon
pushed a commit
that referenced
this pull request
Oct 24, 2024
#1477) ### What Ported the implementation of binary search from Rust <=1.81 to Soroban env. ### Why This is necessary for 2 reasons: - Fix the immediate issue of CI failing due to observation divergence in Rust 1.82 caused by the binary search implementation change - Protect ourselves from the similar issues in the future - we were effectively observing the stdlib implementation and that's incorrect and risky in the long term. ### Known limitations N/A
graydon
pushed a commit
that referenced
this pull request
Oct 24, 2024
#1477) ### What Ported the implementation of binary search from Rust <=1.81 to Soroban env. ### Why This is necessary for 2 reasons: - Fix the immediate issue of CI failing due to observation divergence in Rust 1.82 caused by the binary search implementation change - Protect ourselves from the similar issues in the future - we were effectively observing the stdlib implementation and that's incorrect and risky in the long term. ### Known limitations N/A (cherry picked from commit ee8afb3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ported the implementation of binary search from Rust <=1.81 to Soroban env.
Why
This is necessary for 2 reasons:
Known limitations
N/A