Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported the implementation of binary search from Rust <=1.81 to Soroban #1477

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Ported the implementation of binary search from Rust <=1.81 to Soroban #1477

merged 2 commits into from
Oct 21, 2024

Commits on Oct 21, 2024

  1. Ported the implementation of binary search from Rust <=1.81 to Soroba… 

    …n env.

This is necessary for 2 reasons:

- Fix the immediate issue of CI failing due to observation divergence in Rust 1.82 caused by the binary search implementation change
- Protect ourselves from the similar issues in the future - we were effectively observing the stdlib implementation and that's incorrect and risky in the long term.
    @dmkozh
    dmkozh committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b9fdc42 View commit details
    Browse the repository at this point in the history

  2. !fixup remove unsafe

    @dmkozh
    dmkozh committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    41f4773 View commit details
    Browse the repository at this point in the history