Fix first/last_index_of functions to use deep object comparison
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Dec 15, 2022
|
@jayz22 Thanks for fixing this! I already merged, but do you mind adding a test case as well in another PR? |
sisuresh
added a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
Dec 15, 2022
### What Revert #798 and update env to pull in this bug fix - stellar/rs-soroban-env#612. I'm reverting the deploy change so we can update our examples with this fix and have a more up to date set of changes that we can release if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the bug in examples discovered earlier by @sisuresh, by using deep object comparisons in host vector's
first/last_index_offunctionsWhy
HostVeccontainsRawVals which may be objects of the identical in content have different object handles, thus deep comparison is needed.Known limitations
[TODO or N/A]