Remove token deploy in anticipation of removal of the soroban only built-in token #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this change will make it harder to experiment with contracts that interact with tokens because it'll require every developer wanting to interact with a contract to develop their own. I guess soon enough there will be a standard WASM token contract that people can use for testing? It feels like we're going to have a testing hole though. This doesn't need to block this, just noticing. |
|
Ignore my message above, I misunderstood. I see that there is still the SAC for testing within the SDK. |
leighmcculloch
approved these changes
Dec 15, 2022
sisuresh
added a commit
to sisuresh/rs-soroban-sdk
that referenced
this pull request
Dec 15, 2022
… only built-in token (stellar#798)" This reverts commit 62a2030.
sisuresh
added a commit
that referenced
this pull request
Dec 15, 2022
### What Revert #798 and update env to pull in this bug fix - stellar/rs-soroban-env#612. I'm reverting the deploy change so we can update our examples with this fix and have a more up to date set of changes that we can release if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The soroban-only built-in token is being removed in stellar/rs-soroban-env#607. This is the corresponding sdk change required for updating soroban-test-wasms in rs-soroban-env. This PR does not add support for deploy the Stellar Asset Contract. That can be added in later after we decide what that feature would look like.
Note that the rs-soroban-env version is not being bumped in this PR. That can be done in a later commit once the rs-soroban-env PR is merged.