-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAP-52 XDR #73
CAP-52 XDR #73
Conversation
@jonjove Are you wanting to have this merged to the main branch? It looks like the XDR contained within isn't in stellar-core, because when I run |
@leighmcculloch it took me a while to get all the PRs open, but it corresponds to changes in stellar/stellar-core#3450 and stellar/rs-soroban-env#112. I don't know how we want to sequence these merges. |
@jonjove I think if you want to be strict about it, you should break up stellar/stellar-core#3450 to be two PRs, one that modifies the XDR first, and then one that makes any changes that are dependent on the
We may as well have the XDR in its own repo. cc @MonsieurNicolas @graydon How did you do this recently? |
Until we figure this out I think it's fine if you merge this just before merging the stellar-core PR, assuming the .x files are identical. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment in the accompanying core XDR change that I think the return from the function should have an SCVal and so this would need to be regenerated to match if so. Otherwise ok.
What
Add the XDR for CAP-52, specifically
InvokeHostFunctionOp
.Why
Required to support CAP-52 in stellar/rs-stellar-contract-env and stellar/stellar-core.
Known limitations
N/A