Implement the InvokeHostFunctionOp part of CAP-52 #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
requested changes
Jun 15, 2022
jayz22
reviewed
Jun 15, 2022
src/rust/src/contract.rs
Outdated
| /// Deserializes an [`xdr::HostFunction`] host function identifier, an [`xdr::ScVec`] XDR object of | ||
| /// arguments, an [`xdr::Footprint`] and a sequence of [`xdr::LedgerEntry`] entries containing all | ||
| /// the data the invocation intends to read. Then calls the host function with the specified | ||
| /// arguments and serializes the [`xdr::ScVal`] return value |
There was a problem hiding this comment.
This comment is inaccurate, the return value of the host function call is thrown away. Instead the ReadWrite set is serialized and returned.
stellar/rs-stellar-contract-env
sisuresh
reviewed
Jun 15, 2022
graydon
approved these changes
Jun 16, 2022
|
LGTM -- I leave the landing sequence to you, I think you might need to merge the other 2 first and then bump the Cargo.toml here to point to the post-merge revision ID of the env crate. |
|
r+ a68b53e |
|
r+ b1d22f7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the
InvokeHostFunctionOppart of CAP-52, but does not include the host functions.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)