Protocol 22 Breaking changes #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Encode createdAt as a string for JS support
* Cleanup old retention-windows and increase history-retention-window to 7 days * fix tests
Speed up startup time in "already migrated" cases by eliminating unnecessary ledger range traversals. Specifically, this includes the following changes: - Fee stats windows cannot exceed the history retention window, as this doesn't make sense. - Migrations that are already applied are not added to the list of "multi-migrations". - Fee stats window building conforms to the migration interface to simplify code. - LedgerSeqRange has been refactored to always use a value reference. As a result, if all migrations have occurred, the traversal only occurs over the fee window.
* Use GetLedgerRange to get the latest ledger * Remove latestLedger key from meta table * Remove latestLedger key from meta table - 2 * Fix failing unittest - 1 * Remove cache check condition * Fix failing unittest - 2 * Uncomment failing ledger entry test * Remove db.SessionInterface param * Fix failing unittest * Cache ledger range - 1 * Cache ledger range - 2 * Cache ledger range - 3 * Cache ledger range - 4 * Fix failing test * Fix failing test - 2 * Fix linting - 1 * Fix linting - 2 * Reduce the time further * Remove creating transaction for GetLedgerRange * Remove creating transaction for GetLedgerRange - 2 * Remove creating transaction for GetLedgerRange - 3 * Fix failing unittest - 1 * Fix failing tests - 2 * Update cmd/soroban-rpc/internal/db/ledger.go Co-authored-by: tamirms <tamirms@gmail.com> * Add check for empty result in ledger range * Add a cache check on GetLatestLedgerSequence call * Move cache read to DB function * Move cache read to DB function - 2 * Revert "Move cache read to DB function - 2" This reverts commit f7ebe3e. * Lock cache before creating tx * Fix failing test * Add migration * Fix failing test * Refactor NewTx and NewCachedTx * Refactor NewTx and NewCachedTx - 2 * Refactor NewTx and NewCachedTx - 3 * Refactor NewTx and NewCachedTx - 4 --------- Co-authored-by: tamirms <tamirms@gmail.com>
…#285) * Replace internal error package * Replace internal error package in getEvents * remove nolint * go fmt * Fix lint pt1 * Fix lint pt2 * Fix lint pt3 - remove global var in getEvents * Fix lint pt4
* Fix config lint * Fix daemon lint * Fix db lint * Fix feewindow lint * Fix ingest lint * Fix ledgerbucketwindow lint * Fix ingest lint - 2 * Fix preflight lint * Small fixes - 1 * Clean up * gci file
* bump horizon to latest release tag * go mod tidy
* Remove RELEASING.md * Remove images
* simulate-transaction: remove confusing Cost field in response * Appease linter
* Add endLedger in GetEventResponse * Add Cursor to response and deprecate PagingToken * Update cursor logic and tests * update CHANGELOG.md
Add transaction hash in the transaction object in the getTransactions response
* Update docker file to build 2 images based on argument * Update docker-build and makefile * remove duplicate assignments
willemneal
reviewed
Oct 2, 2024
1 task
mollykarcher
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the accumulated deprecations breaking-changes we will release for procotol22