Fix: error, enum, union types

[willemneal]

What

Upgrade to new error type and fix other types.

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

Currently invoke.ts is failing because of xdr change.

[willemneal]

@paulbellamy It's failing to find the xdr in the test wasms. Could there be a version mismatch? I'm very confused how this could happen.

[paulbellamy]

Couple small suggestions, but looks fine.

[willemneal]

The invoke.ts is failing on this line:

 const auth = SorobanClient.xdr.SorobanAuthorizationEntry.fromXDR(auths![0]!, 'base64')
    if (auth.addressWithNonce() !== undefined) {
      throw new NotImplementedError(
        `This transaction needs to be signed by ${auth.addressWithNonce()
        }; Not yet supported`
      )
    }

SorobanAuthorizationEntry does not seem to be defined. How is this done now?

[paulbellamy]

You probably need stellar/js-soroban-client#103, because that updates the XDR

[willemneal]

Should we pause this PR until then? Or merge and make one just for updating that?

[kalepail]

Is there a clean way to test this before preview 10 is live? I'd love for this typescript bindings thing to work well but I'm currently blocked on errors and apparently this PR may help me

[kalepail]

Alright I did

cargo install --git https://github.com/AhaLabs/soroban-tools --rev 3630239df49f4f0cce2efb22f7ed5e9e4e23ef89 soroban-cli

which installed that commit for this PR however there are still a couple types errors I'm seeing:

Error 1

export async function colors_mine({ miner, to, colors }: { miner: Address, to: Option<Address>, colors: Array<[u32, u32]> }, { signAndSend, fee }: { signAndSend?: boolean, fee?: number } = { signAndSend: false, fee: 100 }): Promise<void> {
    let invokeArgs: InvokeArgs = {
        signAndSend,
        fee,
        method: 'colors_mine',
        args: [((i) => addressToScVal(i))(miner),
        ((i) => (!i) ? xdr.ScVal.scvVoid() : addressToScVal(i))(to),
        ((i) => xdr.ScVal.scvVec(i.map((i) => [
            ((i) => xdr.ScVal.scvU32(i))(i[0]),
            ((i) => xdr.ScVal.scvU32(i))(i[1])
        ])))(colors)],
    };

    // @ts-ignore Type does exist
    const response = await invoke(invokeArgs);
    return;
}

pub fn colors_mine(env: &Env, miner: Address, to: Option<Address>, colors: Vec<(u32, u32)>)

Error 2

export async function glyph_mint({ minter, to, colors, width }: { minter: Address, to: Option<Address>, colors: Array<[Address, Array<[u32, Array<u32>]>]>, width: u32 }, { signAndSend, fee }: { signAndSend?: boolean, fee?: number } = { signAndSend: false, fee: 100 }): Promise<Buffer> {
    let invokeArgs: InvokeArgs = {
        signAndSend,
        fee,
        method: 'glyph_mint',
        args: [((i) => addressToScVal(i))(minter),
        ((i) => (!i) ? xdr.ScVal.scvVoid() : addressToScVal(i))(to),
        ((i) => xdr.ScVal.scvVec(i.map((i) => [
            ((i) => addressToScVal(i))(i[0]),
            ((i) => xdr.ScVal.scvVec(i.map((i) => [
                ((i) => xdr.ScVal.scvU32(i))(i[0]),
                ((i) => xdr.ScVal.scvVec(i.map((i) => xdr.ScVal.scvU32(i))))(i[1])
            ])))(i[1])
        ])))(colors),
        ((i) => xdr.ScVal.scvU32(i))(width)],
    };

    // @ts-ignore Type does exist
    const response = await invoke(invokeArgs);
    return scValStrToJs(response.xdr) as Buffer;
}

pub fn glyph_mint(
    env: &Env,
    minter: Address,
    to: Option<Address>,
    colors: Vec<(Address, Vec<(u32, Vec<u32>)>)>,
    width: u32,
) -> BytesN<32>

Error 3

function GlyphToXdr(glyph?: Glyph): xdr.ScVal {
    if (!glyph) {
        return xdr.ScVal.scvVoid();
    }
    let arr = [
        new xdr.ScMapEntry({
            key: ((i) => xdr.ScVal.scvSymbol(i))("colors"), val: ((i) => xdr.ScVal.scvVec(i.map((i) => [
                ((i) => addressToScVal(i))(i[0]),
                ((i) => xdr.ScVal.scvVec(i.map((i) => [
                    ((i) => xdr.ScVal.scvU32(i))(i[0]),
                    ((i) => xdr.ScVal.scvVec(i.map((i) => xdr.ScVal.scvU32(i))))(i[1])
                ])))(i[1])
            ])))(glyph["colors"])
        }),
        new xdr.ScMapEntry({ key: ((i) => xdr.ScVal.scvSymbol(i))("length"), val: ((i) => xdr.ScVal.scvU32(i))(glyph["length"]) }),
        new xdr.ScMapEntry({ key: ((i) => xdr.ScVal.scvSymbol(i))("width"), val: ((i) => xdr.ScVal.scvU32(i))(glyph["width"]) })
    ];
    return xdr.ScVal.scvMap(arr);
}

[kalepail]

Looks like we're just missing wrapping those bare arrays with a xdr.ScVal.scvVec.

[willemneal]

@tyvdh Tuple structs should work now. It will take some more work and thought to update to use @Shaptic, but I think my future efforts should go in the stellar-base not here. However, in the interest of getting this done, I just kept it here.

@paulbellamy @tsachiherman Currently all tests pass, except the fetch test which is the only one that uses futurenet and it fails with:

Rpc(JsonRpc(Call(ErrorObject { code: InvalidParams, message: "cannot unmarshal key value AAAABgAAAAG8B08PA5NNAYllO8Fa+agxcEEeEDtMSKY4iDBs+6QayAAAABQAAAABAAAAAA== at index 0", data: None })))

Installing a contract to futurenet also has the issue of error: transaction simulation failed: Could not unmarshal transaction.

My guess is that the RPC hasn't been updated yet. But this makes me think we should improve the error messages if the version of the CLI differs from futurenet.

[tsachiherman]

@willemneal , I think that for the purposes of our testing here, we shouldn't use any public network. These network conditions aren't deterministic and could cause non-useful results. Instead, we should run the futurenet tests after we've upgraded the network, as part of the smoke testing.