soroban-cli: Implement soroban contract read with real rpc support #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 6, 2023 10:34
…restore-subcommands
…restore-subcommands
|
Yay! With some modifications we can also have the sandbox lazily read from RPC. |
|
Yeah, the design here needs some work generally. Currently it can only easily read symbol-keyed storage, and only temporary or permanent, not instance storage. And it doesn't show you the remaining expiry on the entry. But it's definitely an improvement as-is. |
paulbellamy
changed the base branch from
soroban-xdr-next
to
cli-bump-restore-subcommands
added 7 commits
July 11, 2023 15:29
…restore-subcommands
added 8 commits
July 11, 2023 20:32
…restore-subcommands
…restore-subcommands
Base automatically changed from
cli-bump-restore-subcommands
to
soroban-xdr-next
July 12, 2023 00:01
tsachiherman
approved these changes
Jul 12, 2023
tsachiherman
added a commit
that referenced
this pull request
Jul 12, 2023
* update go dep xdr for preview 10 * update * soroban-rpc: update code to latest XDR auth and single-function changes (#703) * WIP * WIP * WIP * Add clarification about events * Moar progress * Last compilation fixes * progress * Fix another test * small cleanup * Fix last test * Fix more tests * Fix more tests * Fix another test * Update to a working (if not the absolute latest) xdr * updating xdr in preflight for fees & auth * pass the min entry expiration into preflight * rawval and set updates * Fix udt test wasm * rustfmt * Updating txresult move * use simon's core image build * Get all rpc unit tests compiling (but not passing) * fix up cargo toml rs-soroban-sdk import * Fix ledgerentry test * Fix getEvents test * Fix GetTransactionTest * Upgrade core version for integration tests * Clean up integration tests * Change the simulateTransactionResponse API back to make the changeover simpler for now * Update integration tests expectations for simulateTransaction * Missed one --------- Co-authored-by: Paul Bellamy <paul@stellar.org> * merge with main, and update the go monorepo link. * soroban-rpc: Adapt Go and Rust code to the latest XDR changes (#724) * Sync code with the latest XDR changes * Bump rust and Core dependencies * Update Rust code to the new sdk and env versions * Fix test * Fix ledgerentry tests for new xdr (#725) * preview10: soroban-cli xdr updates (#722) * StorageType support * Fix VecM max lengths * Fix LedgerKeyNonce conversion * partial ScStatus -> ScError updates * Working on updating for new contract code and entry storage * updating for new xdr * update rs-soroban-sdk to commit e90db9f8009280516375df6b3ee43a65ff524577 * Updating xdr again * New token spec location * Cargo fmt * Fix binding-generators * Dig out the new invokeHostFunction return value * Fix up last of the build * Clippy shenanigans * use symbol_short macro * Set signature_expiration_ledger for sandbox * fixup! use symbol_short macro * fixup! Set signature_expiration_ledger for sandbox * Clean up a vague error * set expiration on contract codes in sandbox * Set expiration on contract instances on sandbox * Handle expired contract code ledger entries in the sandbox * Include temporary entries from contract read subcommand * Implement ledger entry expiration bumps in sandbox * cargo md-gen * Fix rpc simulateTransaction client tests * Merge origin/main into soroban-xdr-next (#728) * soroban-rpc: bug workaround and test fixes (#726) * updated rs-env and mono repo versions (#741) * updated rs-env for 0.9. and mono repo with latest xdr gen updates * review feedback, fix go ref to soroban-xdr-next-next * update all workspace rs-sdk refs to same in toml * updated the cargo ver to match the gh ref * included cargo.lock and deps check fix * soroban-rpc: Implement preflighting of BumpFootprintExpiration and RestoreFootprint operations (#730) * sync with main (#744) * Fix check-dependencies typos (#723) * Add lab token id command (#693) * Add lab token id command * fix doc * Keep only the strkey id * refactoring --------- Co-authored-by: Paul Bellamy <paul@stellar.org> * fix(bindings-ts): don't delete existing dirs (#733) * fix(bindings-ts): don't delete existing dirs - Rename `root-dir` to `output-dir` to clarify the intent - If `output-dir` already exists, use `output-dir/contract-name` instead * docs: update auto-generated * Upgrade wasm-opt to 0.113 (#736) * fix * fix * update * cargo fmt --------- Co-authored-by: Alfonso Acosta <alfonso@stellar.org> Co-authored-by: Vincent Amouret <vincent.amouret@gmail.com> Co-authored-by: Paul Bellamy <paul@stellar.org> Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com> Co-authored-by: Brian Anderson <andersrb@gmail.com> * Fix bug loading contract spec in sandbox when not deployed (#745) * Fix check-dependencies typos (#723) * Add lab token id command (#693) * Add lab token id command * fix doc * Keep only the strkey id * refactoring --------- Co-authored-by: Paul Bellamy <paul@stellar.org> * fix(bindings-ts): don't delete existing dirs (#733) * fix(bindings-ts): don't delete existing dirs - Rename `root-dir` to `output-dir` to clarify the intent - If `output-dir` already exists, use `output-dir/contract-name` instead * docs: update auto-generated * Upgrade wasm-opt to 0.113 (#736) * fix * fix * update * cargo fmt * Fix bug loading contract spec in sandbox when not deployed * Make fmt * No more 'set' type to test * remove unused import * Fix sandbox contract invoke * Make test invoke quiet so it doesn't spit out events * Set default state expiries in the sandbox * Add a note about a crappy test --------- Co-authored-by: Alfonso Acosta <alfonso@stellar.org> Co-authored-by: Vincent Amouret <vincent.amouret@gmail.com> Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com> Co-authored-by: Brian Anderson <andersrb@gmail.com> Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com> * soroban-rpc: State Expiration (#695) * Update go for new xdr * WIP -- working on extensions * Implement ExtendLedgerEntry * Disallow access to expired ledgerEntries * update go dep * Include current ledger in expiry * update ledgerEntry tests for new xdr * Add unit test for ExtendEntry * Add test for extending a non-existent ledger entry * Add tests for expired contract entries * Test creating and extending in the same batch * Show expired ledger entries now that core will autobump * Revert "Show expired ledger entries now that core will autobump" This reverts commit b1426a7. * Refactor expiry checking * Replace assert.NotNil with require.NotNil * Clearer naming * better test error checking * Add validation on upserting ledger entrys that the key matches * Simplify UpsertLedgerEntry since key is derived from the entry * Update go dependency to 3f69f56e3743bbd520e4c25f44b8fc49b1b81936 * soroban-rpc: Fix integration test phrasing (#747) * soroban-rpc: Fix phrasing in an integration test * fix typo * Fix: error, enum, union types (#731) * StorageType support * Fix VecM max lengths * Fix LedgerKeyNonce conversion * partial ScStatus -> ScError updates * Working on updating for new contract code and entry storage * updating for new xdr * update rs-soroban-sdk to commit e90db9f8009280516375df6b3ee43a65ff524577 * Updating xdr again * New token spec location * Cargo fmt * Fix binding-generators * Dig out the new invokeHostFunction return value * Fix up last of the build * Clippy shenanigans * use symbol_short macro * Set signature_expiration_ledger for sandbox * fixup! use symbol_short macro * fixup! Set signature_expiration_ledger for sandbox * Clean up a vague error * set expiration on contract codes in sandbox * Set expiration on contract instances on sandbox * Handle expired contract code ledger entries in the sandbox * Include temporary entries from contract read subcommand * Implement ledger entry expiration bumps in sandbox * cargo md-gen * Fix rpc simulateTransaction client tests * fix: tuples and enums/unions and new Error type * chore: pr review * pull in some fixes * tuples are friends not food * fix: update example inputs to instruct a tuple struct * feat: add tuple struct support * fix: update to use new bindings out-dir --------- Co-authored-by: Paul Bellamy <paul@stellar.org> Co-authored-by: Tyler van der Hoeven <hi@tyvdh.com> * cargo fmt * compile: disable the fetch test (#750) * disable the fetch test, since it's testing it against futurenet. * update boilerplate test. * Fix bug in cli lab xdr decode --type parsing (#751) * soroban-cli: Verify the network passphrase provided matches the server (#754) * soroban-cli: fix contract deploy (#755) * Fix return type parsing from soroban-rpc * soroban-cli: Fix how contract code hashes are calculated * Fix integration test * Bump version to 0.9.0 (#758) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * soroban-rpc: Add bump footprint test (#746) * Bump Core version (#759) * update (#760) * soroban-rpc: Restore footprint fixes (#761) * update e2e tests (#762) * update * update * update package.json to use the official js-soroban-client tag instead of an arbitrary commit hash.. * rollback package changes. * really rollback. * soroban-cli: Add super basic `contract bump` and `contract restore` subcommands (#748) * add contract read --durability filter * Add soroban contract bump subcommand * Add soroban contract restore command * Add support for restoring multiple keys at once * cargo md-gen * Clean up an unused error * Need to increment the account sequence for bump+restore * no --ledgers-to-expire for restore command * Support bump+restore commands in preflight+transaction::assemble * rust fmt * cargo md-gen * Require --durability for bump because the default is confusing * Fix clippy * cargo md-gen * soroban-cli: Implement soroban contract read with real rpc support (#756) * add contract read --durability filter * Add soroban contract bump subcommand * Add soroban contract restore command * Add support for restoring multiple keys at once * cargo md-gen * implement soroban contract read with a real network * Clean up an unused error * Make fmt * cargo md-gen * getLedgerEntries.results can be null * Need to increment the account sequence for bump+restore * no --ledgers-to-expire for restore command * Support bump+restore commands in preflight+transaction::assemble * rust fmt * cargo md-gen * Require --durability for bump because the default is confusing * Fix clippy * cargo md-gen --------- Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com> * update e2e tests (#765) * update * update hash -> 0.9.0 --------- Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com> Co-authored-by: Alfonso Acosta <alfonso@stellar.org> Co-authored-by: shawn <sreuland@users.noreply.github.com> Co-authored-by: Vincent Amouret <vincent.amouret@gmail.com> Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com> Co-authored-by: Brian Anderson <andersrb@gmail.com> Co-authored-by: Willem Wyndham <willem@ahalabs.dev> Co-authored-by: Tyler van der Hoeven <hi@tyvdh.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for talking to soroban-rpc to the
soroban contract read ...subcommand.Why
Previously it only supported against local sandbox ledger.json. But that's not super useful, and we have the new
getLedgerEntriesmethod we can use.I wanted this when I was trying to test/debug the
soroban contract bumpandrestorecommands in #748 (which this is based on)Known limitations
[TODO or N/A]