Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v22 cost types for rolling back wasmi change #4495

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Oct 3, 2024

Description

Here is a gist with the diff of budget.rs between v21.0.0 and v22.0.0-rc.2 - https://gist.github.com/sisuresh/7c89270bab9ab2fb09a43beb98aaeab7.

Command used for the gist - git diff v21.0.0:soroban-env-host/src/budget.rs v22.0.0-rc.2:soroban-env-host/src/budget.rs

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but do we also want to bump env? Or will that be a separate PR?

@graydon
Copy link
Contributor

graydon commented Oct 3, 2024

Approved, but do we also want to bump env? Or will that be a separate PR?

Already did, yesterday.

@sisuresh sisuresh added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@sisuresh sisuresh added this pull request to the merge queue Oct 3, 2024
Merged via the queue into stellar:master with commit 3007c59 Oct 3, 2024
13 checks passed
@sisuresh sisuresh deleted the v22-cost branch October 3, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants