Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[services] introduce sonic.target #10

Closed
wants to merge 5 commits into from

Conversation

stepanblyschak
Copy link
Owner

@stepanblyschak stepanblyschak commented Oct 26, 2020

admin@r-tigon-11:~$ docker ps
CONTAINER ID        IMAGE                                COMMAND                  CREATED             STATUS              PORTS               NAMES
45cb06505f6a        docker-sonic-telemetry:latest        "/usr/bin/supervisord"   About an hour ago   Up 9 minutes                            telemetry
afb299c49d4c        docker-snmp:latest                   "/usr/bin/supervisord"   About an hour ago   Up 9 minutes                            snmp
5c75d20d71cf        docker-sonic-mgmt-framework:latest   "/usr/bin/supervisord"   About an hour ago   Up 9 minutes                            mgmt-framework
3e0563cd556f        docker-router-advertiser:latest      "/usr/bin/docker-ini…"   About an hour ago   Up 12 minutes                           radv
65f94b300db1        docker-platform-monitor:latest       "/usr/bin/docker_ini…"   About an hour ago   Up About a minute                       pmon
4ffadb5817aa        docker-dhcp-relay:latest             "/usr/bin/docker_ini…"   About an hour ago   Up 12 minutes                           dhcp_relay
65058396277c        docker-lldp:latest                   "/usr/bin/docker-lld…"   About an hour ago   Up 12 minutes                           lldp
f922b7a26b06        docker-syncd-mlnx:latest             "/usr/bin/supervisord"   About an hour ago   Up 12 minutes                           syncd
4f3aaddcacf9        docker-teamd:latest                  "/usr/bin/supervisord"   About an hour ago   Up 13 minutes                           teamd
c3622c5322b2        docker-orchagent:latest              "/usr/bin/docker-ini…"   About an hour ago   Up 13 minutes                           swss
370acc8b2289        docker-fpm-frr:latest                "/usr/bin/docker_ini…"   About an hour ago   Up 13 minutes                           bgp
16f359ad4057        docker-database:latest               "/usr/local/bin/dock…"   About an hour ago   Up 13 minutes                           database
admin@r-tigon-11:~$ sudo systemctl stop sonic.target
admin@r-tigon-11:~$ docker ps
CONTAINER ID        IMAGE                    COMMAND                  CREATED             STATUS              PORTS               NAMES
16f359ad4057        docker-database:latest   "/usr/local/bin/dock…"   About an hour ago   Up 14 minutes                           database
admin@r-tigon-11:~$ sudo systemctl restart sonic.target
admin@r-tigon-11:~$ docker ps
CONTAINER ID        IMAGE                                COMMAND                  CREATED             STATUS              PORTS               NAMES
45cb06505f6a        docker-sonic-telemetry:latest        "/usr/bin/supervisord"   About an hour ago   Up 11 seconds                           telemetry
afb299c49d4c        docker-snmp:latest                   "/usr/bin/supervisord"   About an hour ago   Up 6 seconds                            snmp
5c75d20d71cf        docker-sonic-mgmt-framework:latest   "/usr/bin/supervisord"   About an hour ago   Up 8 seconds                            mgmt-framework
3e0563cd556f        docker-router-advertiser:latest      "/usr/bin/docker-ini…"   About an hour ago   Up 16 seconds                           radv
65f94b300db1        docker-platform-monitor:latest       "/usr/bin/docker_ini…"   About an hour ago   Up 17 seconds                           pmon
4ffadb5817aa        docker-dhcp-relay:latest             "/usr/bin/docker_ini…"   About an hour ago   Up 17 seconds                           dhcp_relay
65058396277c        docker-lldp:latest                   "/usr/bin/docker-lld…"   About an hour ago   Up 17 seconds                           lldp
f922b7a26b06        docker-syncd-mlnx:latest             "/usr/bin/supervisord"   About an hour ago   Up 18 seconds                           syncd
4f3aaddcacf9        docker-teamd:latest                  "/usr/bin/supervisord"   About an hour ago   Up About a minute                       teamd
c3622c5322b2        docker-orchagent:latest              "/usr/bin/docker-ini…"   About an hour ago   Up About a minute                       swss
370acc8b2289        docker-fpm-frr:latest                "/usr/bin/docker_ini…"   About an hour ago   Up About a minute                       bgp
16f359ad4057        docker-database:latest               "/usr/local/bin/dock…"   About an hour ago   Up 17 minutes                           database

Signed-off-by: Stepan Blyschak stepanb@nvidia.com

- Why I did it

- How I did it

- How to verify it

Together with sonic-net/sonic-utilities#1199

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@stepanblyschak
Copy link
Owner Author

@volodymyrsamotiy

admin@r-tigon-11:~$ docker ps
CONTAINER ID        IMAGE                                COMMAND                  CREATED             STATUS              PORTS               NAMES
45cb06505f6a        docker-sonic-telemetry:latest        "/usr/bin/supervisord"   About an hour ago   Up 9 minutes                            telemetry
afb299c49d4c        docker-snmp:latest                   "/usr/bin/supervisord"   About an hour ago   Up 9 minutes                            snmp
5c75d20d71cf        docker-sonic-mgmt-framework:latest   "/usr/bin/supervisord"   About an hour ago   Up 9 minutes                            mgmt-framework
3e0563cd556f        docker-router-advertiser:latest      "/usr/bin/docker-ini…"   About an hour ago   Up 12 minutes                           radv
65f94b300db1        docker-platform-monitor:latest       "/usr/bin/docker_ini…"   About an hour ago   Up About a minute                       pmon
4ffadb5817aa        docker-dhcp-relay:latest             "/usr/bin/docker_ini…"   About an hour ago   Up 12 minutes                           dhcp_relay
65058396277c        docker-lldp:latest                   "/usr/bin/docker-lld…"   About an hour ago   Up 12 minutes                           lldp
f922b7a26b06        docker-syncd-mlnx:latest             "/usr/bin/supervisord"   About an hour ago   Up 12 minutes                           syncd
4f3aaddcacf9        docker-teamd:latest                  "/usr/bin/supervisord"   About an hour ago   Up 13 minutes                           teamd
c3622c5322b2        docker-orchagent:latest              "/usr/bin/docker-ini…"   About an hour ago   Up 13 minutes                           swss
370acc8b2289        docker-fpm-frr:latest                "/usr/bin/docker_ini…"   About an hour ago   Up 13 minutes                           bgp
16f359ad4057        docker-database:latest               "/usr/local/bin/dock…"   About an hour ago   Up 13 minutes                           database
admin@r-tigon-11:~$ sudo systemctl stop sonic.target
admin@r-tigon-11:~$ docker ps
CONTAINER ID        IMAGE                    COMMAND                  CREATED             STATUS              PORTS               NAMES
16f359ad4057        docker-database:latest   "/usr/local/bin/dock…"   About an hour ago   Up 14 minutes                           database
admin@r-tigon-11:~$ sudo systemctl restart sonic.target
admin@r-tigon-11:~$ docker ps
CONTAINER ID        IMAGE                                COMMAND                  CREATED             STATUS              PORTS               NAMES
45cb06505f6a        docker-sonic-telemetry:latest        "/usr/bin/supervisord"   About an hour ago   Up 11 seconds                           telemetry
afb299c49d4c        docker-snmp:latest                   "/usr/bin/supervisord"   About an hour ago   Up 6 seconds                            snmp
5c75d20d71cf        docker-sonic-mgmt-framework:latest   "/usr/bin/supervisord"   About an hour ago   Up 8 seconds                            mgmt-framework
3e0563cd556f        docker-router-advertiser:latest      "/usr/bin/docker-ini…"   About an hour ago   Up 16 seconds                           radv
65f94b300db1        docker-platform-monitor:latest       "/usr/bin/docker_ini…"   About an hour ago   Up 17 seconds                           pmon
4ffadb5817aa        docker-dhcp-relay:latest             "/usr/bin/docker_ini…"   About an hour ago   Up 17 seconds                           dhcp_relay
65058396277c        docker-lldp:latest                   "/usr/bin/docker-lld…"   About an hour ago   Up 17 seconds                           lldp
f922b7a26b06        docker-syncd-mlnx:latest             "/usr/bin/supervisord"   About an hour ago   Up 18 seconds                           syncd
4f3aaddcacf9        docker-teamd:latest                  "/usr/bin/supervisord"   About an hour ago   Up About a minute                       teamd
c3622c5322b2        docker-orchagent:latest              "/usr/bin/docker-ini…"   About an hour ago   Up About a minute                       swss
370acc8b2289        docker-fpm-frr:latest                "/usr/bin/docker_ini…"   About an hour ago   Up About a minute                       bgp
16f359ad4057        docker-database:latest               "/usr/local/bin/dock…"   About an hour ago   Up 17 minutes                           database

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
'Conficts=' in timer units caused a problem when
starting a timer causes restart of a service.
Instead, 'PartOf=' is a better choice.
'PartOf=' will make the timer stop and restart togather
with the service the timer is bound to, otherwise the timer
OnUnitActiveSec expires imidiatelly when the service stops
and starts it.

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
To prevent restarts on 'systemctl start <service>'.

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
stepanblyschak pushed a commit that referenced this pull request Nov 11, 2021
* Upgrade new DellEMC platforms to Bullseye

* Update s5212f kernel module
stepanblyschak pushed a commit that referenced this pull request Jan 24, 2022
* [BFN] Updated platform APIs impl

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Extended BFN platform SFP APIs implementation

* Update sfp.py

* [BFN] Extended SFP platform plugin implementation

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [BFN] Extended Fans platform plugin implementation

* [BFN] divided classes Fan and  FanDrawer into 2 files

* Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

What I did
	Add get_model() function
	Add get_low_critical_threshold() function
	Change __get(...) function.
How I did it
	Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API

* Add get_presence() function and revised __get() function

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

* [BFN] Updated PSU platform APIs impl

Signed-off-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com>

* Added BFN PSU cache (#9)

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [BFN]  Fans and Fantray platform APIs update (#7)

* [BFN] Updated SFP platform APIs (#10)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* [BFN] Updated platform API for thermal (#8)

* Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

* Revert "[BFN]  Fans and Fantray platform APIs update (#7)" (#11)

This reverts commit c62a733.

* Add support health monitor system (#15)

Signed-off-by: Petro Bratash <petrox.bratash@intel.com>

* Update chassis.py

* [BFN] Updated FANs and FAN Tray platform API (#14)

* Fix fix_alignment (#17)

Signed-off-by: Petro Bratash <petrox.bratash@intel.com>

* [BFN] Improvement show environment (#16)

* Added PSU temperature skip into platform.json (#18)

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Do not skip psud on Newport

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [BFN] fix fan status from Not OK to Ok (#19)

* [BFN] Updated SFP platform plugin (#13)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21)

Signed-off-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>

* [barefoot] Tmp fix vendor_rev (#22)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* Fixed python issues in sonic_platform/fan_drawer.py

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Updated fan_drawer.py

* Fixing trailing white spaces in fan_drawer.py

* [BFN] Fix thrift for SFPs API

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [Newport] Thermal manager  (#23)

* Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

* Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue"

This reverts commit 1e73127.

* Removed 'controllable' options from platform.json to fix factory default config generation

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Update thermal_manager.py

* Migrated SFP plugin to sonic_xcvr API (#30)

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

Co-authored-by: KostiantynYarovyiBf <kostiantynx.yarovyi@intel.com>
Co-authored-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>
Co-authored-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com>
Co-authored-by: Volodymyr Boiko <volodymyrx.boiko@intel.com>
Co-authored-by: Petro Bratash <petrox.bratash@intel.com>
Co-authored-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>
@stepanblyschak stepanblyschak deleted the sonic_target_internal branch September 23, 2022 13:31
stepanblyschak pushed a commit that referenced this pull request Nov 9, 2022
#### Why I did it
Update sonic-host-services submodule to include below commits:
```
bc8698d Merge pull request #21 from abdosi/feature
557a110 Fix the issue where if dest port is not specified in ACL rule than for multi-asic where we create NAT rule to forward traffic from Namespace to host fail with exception.
6e45acc (master) Merge pull request #14 from abdosi/feature
4d6cad7 Merge remote-tracking branch 'upstream/master' into feature
bceb13e Install libyang to azure pipeline (#20)
82299f5 Merge pull request #13 from SuvarnaMeenakshi/cacl_fabricns
15d3bf4 Merge branch 'master' into cacl_fabricns
de54082 Merge pull request #16 from ZhaohuiS/feature/caclmgrd_external_client_warning_log
b4b368d Add warning log if destination port is not defined
d4bb96d Merge branch 'master' into cacl_fabricns
35c76cb Add unit-test and fix typo.
17d44c2 Made Changes to be Python 3.7 compatible
978afb5 Aligning Code
1fbf8fb Merge remote-tracking branch 'upstream/master' into feature
7b8c7d1 Added UT for the changes
91c4c42 Merge pull request #9 from ZhaohuiS/feature/caclmgrd_external_client
7c0b56a Add 4 test cases for external_client_acl, including single port and port range for ipv4 and ipv6
b71e507 Merge remote-tracking branch 'origin/master' into HEAD
d992dc0 Merge branch 'master' into feature/caclmgrd_external_client
bd7b172 DST_PORT is configuralbe in json config file for EXTERNAL_CLIENT_ACL
f9af7ae [CLI] Move hostname, mgmt interface/vrf config to hostcfgd (#2)
70ce6a3 Merge pull request #10 from sujinmkang/cold_reset
29be8d2 Added Support to render Feature Table using Device running metadata. Also added support to render 'has_asic_scope' field of Feature Table.
3437e35 [caclmgrd][chassis]: Add ip tables rules to accept internal docker traffic from fabric asic namespaces.
8720561 Fix and add hardware reboot cause determination tests
0dcc7fe remove the empty bracket if no hardware reboot cause minor
e47d831 fix the wrong expected result comparision
ef86b53 Fix startswith Attribute error
8a630bb fix mock patch
8543ddf update the reboot cause logic and update the unit test
53ad7cd fix the mock patch function
7c8003d fix the reboot-cause regix for test
1ba611f fix typo
25379d3 Add unit test case
a56133b Add hardware reboot cause as actual reboot cause for soft reboot failed
c7d3833 Support Restapi/gnmi control plane acls
f6ea036 caclmgrd: Don't block traffic to mgmt by default
a712fc4 Update test cases
adc058b caclmgrd: Don't block traffic to mgmt by default
06ff918 Merge pull request #7 from bluecmd/patch-1
e3e23bc ci: Rename sonic-buildimage repository
e83a858 Merge pull request #4 from kamelnetworks/acl-ip2me-test
f5a2e50 [caclmgrd]: Tests for IP2ME rules generation
```
stepanblyschak pushed a commit that referenced this pull request Oct 30, 2023
- Why I did it
Mellanox MSN2700 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely.

- How I did it
Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf

- How to verify it
run regression on the MSN2700 platform to make the error log will not be printed to the syslog.

Signed-off-by: Kebo Liu <kebol@nvidia.com>
stepanblyschak pushed a commit that referenced this pull request Dec 5, 2023
…#17365)

- Why I did it
Mellanox MSN2410 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely

- How I did it
Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf

- How to verify it
run regression on the MSN2410 platform to make the error log will not be printed to the syslog.

Signed-off-by: Kebo Liu <kebol@nvidia.com>
stepanblyschak pushed a commit that referenced this pull request Dec 20, 2023
…#17365)

- Why I did it
Mellanox MSN2410 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely

- How I did it
Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf

- How to verify it
run regression on the MSN2410 platform to make the error log will not be printed to the syslog.

Signed-off-by: Kebo Liu <kebol@nvidia.com>
stepanblyschak pushed a commit that referenced this pull request Dec 21, 2023
…buf (sonic-net#17521)

* [submodule]: Update submodule sonic-swss/sonic-dash-api/protobuf (sonic-net#17413)

1. Protobuf 3.21 has been released in the Debian bookworm
2. Update submodule sonic-swss and sonic-dash-api because they include related updates.

- Microsoft ADO **(number only)**:

1. In the protobuf.mk, If it isn't bullseye, ignore to compile the protobuf package
2. Move sonic-swss commits:
```
fd852084 (HEAD, origin/master, origin/HEAD) [dashrouteorch]: Rename dash route namespace (sonic-net#2966)
```
3. Move sonic-dash-api and move build chain to its submodule
```
d4448c7 (HEAD, origin/master, origin/HEAD, master) [azp]: Add multi-platform artifacts (#11)
8a5e5cc [debian]: Add debian package (#10)
d96163a [misc]: Add dash utils and its tests (#9)
```

Signed-off-by: Ze Gan <ganze718@gmail.com>
stepanblyschak pushed a commit that referenced this pull request Jan 4, 2024
…ic-net#17413)

### Why I did it
1. Protobuf 3.21 has been released in the Debian bookworm
2. Update submodule sonic-swss and sonic-dash-api because they include related updates.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

1. In the protobuf.mk, If it isn't bullseye, ignore to compile the protobuf package
2. Move sonic-swss commits:
```
fd852084 (HEAD, origin/master, origin/HEAD) [dashrouteorch]: Rename dash route namespace (sonic-net#2966)
```
3. Move sonic-dash-api and move build chain to its submodule
```
d4448c7 (HEAD, origin/master, origin/HEAD, master) [azp]: Add multi-platform artifacts (#11)
8a5e5cc [debian]: Add debian package (#10)
d96163a [misc]: Add dash utils and its tests (#9)
```

#### How to verify it
Check Azp
stepanblyschak pushed a commit that referenced this pull request Dec 17, 2024
…et#21095)

Adding the below fix from FRR FRRouting/frr#17297

This is to fix the following crash which is a statistical issue

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra -A 127.0.0.1 -s 90000000 -M dplane_fpm_nl -M snmp'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
[Current thread is 1 (Thread 0x7fccd6faf7c0 (LWP 36))]
(gdb) bt
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fccd7302fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007fccd72ed472 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#3  0x00007fccd75bb3a9 in _zlog_assert_failed (xref=xref@entry=0x7fccd7652380 <_xref.16>, extra=extra@entry=0x0) at ../lib/zlog.c:678
#4  0x00007fccd759b2fe in route_node_delete (node=<optimized out>) at ../lib/table.c:352
#5  0x00007fccd759b445 in route_unlock_node (node=0x0) at ../lib/table.h:258
#6  route_next (node=<optimized out>) at ../lib/table.c:436
#7  route_next (node=node@entry=0x56029d89e560) at ../lib/table.c:410
#8  0x000056029b6b6b7a in if_lookup_by_name_per_ns (ns=ns@entry=0x56029d873d90, ifname=ifname@entry=0x7fccc0029340 "PortChannel1020")
    at ../zebra/interface.c:312
#9  0x000056029b6b8b36 in zebra_if_dplane_ifp_handling (ctx=0x7fccc0029310) at ../zebra/interface.c:1867
#10 zebra_if_dplane_result (ctx=0x7fccc0029310) at ../zebra/interface.c:2221
#11 0x000056029b7137a9 in rib_process_dplane_results (thread=<optimized out>) at ../zebra/zebra_rib.c:4810
#12 0x00007fccd75a0e0d in thread_call (thread=thread@entry=0x7ffe8e553cc0) at ../lib/thread.c:1990
#13 0x00007fccd7559368 in frr_run (master=0x56029d65a040) at ../lib/libfrr.c:1198
#14 0x000056029b6ac317 in main (argc=9, argv=0x7ffe8e5540d8) at ../zebra/main.c:478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant