forked from sonic-net/sonic-buildimage
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split initialization of sonic_platform to a per-daemon basis #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aemon-base 2. remove dependency on the modules not feasible to install on host, like swsscomm, sdk, etc.
stephenxs
changed the title
Install npapi on host
split initialization of sonic_platform to a per-daemon basis
Jul 15, 2019
…esults from referencing an already destroyed global variable when destructuring daemon_base.Logger by introducing a class member to represent the global
…push on power button
1. removing iniaializations of varient components out from constructor and providing one initializer for each. 2. only import other modules when initializing it. by doing so, initializing time is reduced and unnecessary dependencies of chassis is removed for daemons who don't need them.
we decide to split chassis in a host/daemon basis rather than a per-daemon bases. adjust the argument of Platform() accordingly as well as all code that calls Platform.
I'm going to split this PR into 3 which contain the following logic and then close it.
|
stephenxs
pushed a commit
that referenced
this pull request
Dec 10, 2020
This update brings in the following commits. 86c1108 Enable arm architecture to build in addition to amd64 (#37) 4acb2c3 fix bugs and enhance Transformer (#35) 49e5a22 ygot related enhancements and fixes (#34) 51224de Fix ietf yang search path for cvl schema builds (#32) 3c6cdb3 CVL Changes #8: 'must' and 'when' expression evaluation (#31) dabf231 CVL Changes #7: 'leafref' evaluation (#28) 6f9535f CVL Changes #6: Customized Xpath Engine integration (#27) 5e2466b DB-Layer fixes/enhancements (#26) 9a27302 CVL Changes #4: Implementation of new CVL APIs (#22) dbf1093 Translib support for authorization, yang versioning and Delete flag (#21) 80f369e CVL Changes #5: YParser enhancement (#23) 904ce18 CVL Changes #3: Multi-db instance support (#20) 9d24a34 CVL Changes #2: YValidator infra changes for evaluating xpath expression (#19) f3fc40f CVL Changes #1: Initial CVL code reorganization and common infra changes (#18) 4922601 Bulk and RPC API support in translib (#16) 1d730df RFC7895 yang module library implementation (#15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
split sonic_platform initialization to a per-daemon basis to save the startup time of daemons
make Mellanox new platform api able to be installed on host so that reboot cause can be handled on it.
- How I did it
Platform.__init__(self, daemon = None)
- How to verify it
load chassis on host and check whether reboot-cause and watchdog can be well handled.
load chassis on pmon docker and check whether other components can be well handled.
run process-reboot-cause and check whether the correct reboot cause can be parsed.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)