[sonic_platform]support install firmware #18

stephenxs · 2019-11-21T08:30:23Z

- What I did
support firmware install, including CPLD and BIOS.

- How I did it
CPLD: cpldupdate
BIOS: boot to onie and update BIOS in onie and then boot to SONiC

- How to verify it
try installing CPLD/BIOS via platform api
test-install-sonic-then-update-bios.txt
test-update-cpld-gpio.txt

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

platform/mellanox/mlnx-platform-api/sonic_platform/component.py

nazariig · 2019-12-11T15:12:57Z

platform/mellanox/onie-fw-update

+			rc=$?
+			clean_onie_access
+			if [ $rc -eq 0 ]; then
+				system_reboot


@stephenxs You need to update the script, because it will do the reboot regardless the user action.

ok. will remove it.

@nazariig just FYI, I just remember that after a BIOS upgrade scheduled, the boot sequence of grub will be updated to 2 which will not be recognized by sonic_installer. As a result, any attempt trying to reboot switch via a SONiC command, like "sudo reboot", won't work. The only way to reboot the system is to use /sbin/reboot.
This hint has been printed to the screen after a BIOS upgrade successfully scheduled.

platform/mellanox/mlnx-platform-api/sonic_platform/component.py

nazariig · 2019-12-11T15:17:20Z

@stephenxs please implement "get_name" for chassis object.

platform/mellanox/mlnx-platform-api/sonic_platform/component.py

nazariig · 2019-12-12T11:50:31Z

platform/mellanox/mlnx-platform-api/sonic_platform/component.py

+            result = subprocess.call(ONIE_FW_UPDATE_CMD_ADD.format(image_path).split())
+            if result:
+                return False
+            result = subprocess.call(ONIE_FW_UPDATE_CMD_UPDATE.split())


@stephenxs why not to use _get_command_result here?

we need to print the output to screen. get command result returns output for parsing or comparing. they're different.
all other cases fall into this.

BTW, I'm not going to change the way we capture output when upgrading CPLD. current way works and I don't have more time on it :(

@stephenxs ok. Let's leave it as is.

platform/mellanox/mlnx-platform-api/sonic_platform/component.py

nazariig · 2019-12-12T12:07:49Z

platform/mellanox/mlnx-platform-api/sonic_platform/component.py

@@ -60,12 +74,39 @@ def _get_command_result(self, cmdline):
        return result


@stephenxs do we need also check Exit Code here?

It's OK here.
But it is required in some other place. I added.

@stephenxs ok.

stephenxs · 2019-12-13T03:04:42Z

@stephenxs please implement "get_name" for chassis object.
Chassis will be loaded in both pmon and host. In pmon onie info is not available.
Let's use sku name for now.

the onie-fw-update has been postfixed with ".sh" after installed on the DUT.

…m info

* Added sonic-mgmt-framework as submodule / docker * fix build issues * update sonic-mgmt-framework submodule branch to master * Merged changes 70007e6d2ba3a4c0b371cd693ccc63e0a8906e77..00d4fcfed6a759e40d7b92120ea0ee1f08300fc6 00d4fcfed6a759e40d7b92120ea0ee1f08300fc6 Modified environemnt variables * Changes to build sonic-mgmt-framework docker * bumped up sonic-mgmt-framework commit-id * version bump for sonic-mgmt-framework commit-it * bumped up sonic-mgmt-framework commit-id * Add python packages to docker * Build fix for docker with python packages * added libyang as dependent package * Allow building images on NFS-mounted clones Prior to this change, `build_debian.sh` would generate a Debian filesystem in `./fsroot`. This needs root permissions, and one of the tests that is performed is whether the user can create a character special file in the filesystem (using mknod). On most NFS deployments, `root` is the least privileged user, and cannot run mknod. Also, attempting to run commands like rm or mv as root would fail due to permission errors, since the root user gets mapped to an unprivileged user like `nobody`. This commit changes the location of the Debian filesystem to `/fsroot`, which is a tmpfs mount within the slave Docker. The default squashfs, docker tarball and zip files are also created within /tmp, before being copied back to /sonic as the regular user. The side effect of this change is that the contents of `/fsroot` are no longer available once the slave container exits, however they are available within the squashfs image. Signed-off-by: Nirenjan Krishnan <Nirenjan.Krishnan@dell.com> * bumped up sonc-mgmt-framework commit to include PR #18 * REST Server startup script is enahnced to read the settings from ConfigDB. Below table provides mapping of db field to command line argument name. ============================================================ ConfigDB entry key Field name REST Server argument ============================================================ REST_SERVER|default port -port REST_SERVER|default client_auth -client_auth REST_SERVER|default log_level -v DEVICE_METADATA|x509 server_crt -cert DEVICE_METADATA|x509 server_key -key DEVICE_METADATA|x509 ca_crt -cacert ============================================================ * Replace src/telemetry as submodule to sonic-telemetry * Update telemetry commit HEAD * Update sonic-telemetry commit HEAD * libyang env path update * Add libyang dependency to telemetry * Add scripts to create JSON files for CLI backend Scripts to create /var/platform/syseeprom and /var/platform/system, which are back-end files for CLI, for system EEPROM and system information. Signed-off-by: Howard Persh <Howard_Persh@dell.com> * In startup script, create directory where CLI back-end files live Signed-off-by: Howard Persh <Howard_Persh@dell.com> * build dependency pkgs added to docker for build failure fix * Changes to fix build issue for mgmt framework * Fix exec path issue with telemetry * s5232[device] PSU detecttion and default led state support * Processing of first boot in rc.local should not have premature exit Signed-off-by: Howard Persh <Howard_Persh@dell.com> * docker mount options added for platform, system features * bumped up sonic-mgmt-framework commit id to pick 23rd July 2019 changes * Added mount options for telemetry docker to get access for system and platform info. * Update commit for sonic-utilities * [dell]: Corrected dport map and renamed config files for S5232F * Fix telemetry submodule commit * added support for sonic-cli console * [Dell S5232F, Z9264F] Harden FPGA driver kernel module For Dell S5232F and Z9264F platforms, be more strict when checking state in ISR of FPGA driver, to harden against spurious interrupts. Signed-off-by: Howard Persh <Howard_Persh@dell.com> * update mgmt-framework submodule to 27th Aug commit. * remove changes not related to mgmt-framework and sonic-telemetry * Revert "Replace src/telemetry as submodule to sonic-telemetry" This reverts commit 11c3192. * Revert "Replace src/telemetry as submodule to sonic-telemetry" This reverts commit 11c3192. * make submodule changes and remove a change not related to PR * more changes * Update .gitmodules * Update Dockerfile.j2 * Update .gitmodules * Update .gitmodules * Update .gitmodules reverting experimental change * Removed syspoll for release_1.0 Signed-off-by: Jeff Yin <29264773+jeff-yin@users.noreply.github.com> * Update docker-sonic-mgmt-framework.mk * Update sonic-mgmt-framework.mk * Update sonic-mgmt-framework.mk * Update docker-sonic-mgmt-framework.mk * Update docker-sonic-mgmt-framework.mk * Revert "Processing of first boot in rc.local should not have premature exit" This reverts commit e99a91f. * Remove old telemetry directory * Update docker-sonic-mgmt-framework.mk * Resolving merge conflict with Azure * Reverting the wrong merge * Use CVL_SCHEMA_PATH instead of changing directory for telemetry startup * Add missing export * Add python mmh3 to slave dockerfile * Remove sonic-mgmt-framework build dep for telemetry, fix dialout startup issues * Provided flag to disable compiling mgmt-framework * Update sonic-utilites point latest commit id * Point sonic-utilities to Azure accepted SHA * Updating mgmt framework to right sha * Add sonic-telemetry submodule * Update the mgmt-framework commit id Co-authored-by: jghalam <joe.ghalam@gmail.com> Co-authored-by: Partha Dutta <51353699+dutta-partha@users.noreply.github.com> Co-authored-by: srideepDell <srideep_devireddy@dell.com> Co-authored-by: nirenjan <nirenjan@users.noreply.github.com> Co-authored-by: Sachin Holla <51310506+sachinholla@users.noreply.github.com> Co-authored-by: Eric Seifert <seiferteric@gmail.com> Co-authored-by: Howard Persh <hpersh@yahoo.com> Co-authored-by: Jeff Yin <29264773+jeff-yin@users.noreply.github.com> Co-authored-by: Arunsundar Kannan <31632515+arunsundark@users.noreply.github.com> Co-authored-by: rvasanthm <51932293+rvasanthm@users.noreply.github.com> Co-authored-by: Ashok Daparthi-Dell <Ashok_Daparthi@Dell.com> Co-authored-by: anand-kumar-subramanian <51383315+anand-kumar-subramanian@users.noreply.github.com>

* src/sonic-ztp c959371...dd025bc (2): > Update all references to new 'sonic-installer' file name (#18) > Filter out non-printable characters read from syseeprom (#17)

This update brings in the following commits. 86c1108 Enable arm architecture to build in addition to amd64 (#37) 4acb2c3 fix bugs and enhance Transformer (#35) 49e5a22 ygot related enhancements and fixes (#34) 51224de Fix ietf yang search path for cvl schema builds (#32) 3c6cdb3 CVL Changes #8: 'must' and 'when' expression evaluation (#31) dabf231 CVL Changes #7: 'leafref' evaluation (#28) 6f9535f CVL Changes #6: Customized Xpath Engine integration (#27) 5e2466b DB-Layer fixes/enhancements (#26) 9a27302 CVL Changes #4: Implementation of new CVL APIs (#22) dbf1093 Translib support for authorization, yang versioning and Delete flag (#21) 80f369e CVL Changes #5: YParser enhancement (#23) 904ce18 CVL Changes #3: Multi-db instance support (#20) 9d24a34 CVL Changes #2: YValidator infra changes for evaluating xpath expression (#19) f3fc40f CVL Changes #1: Initial CVL code reorganization and common infra changes (#18) 4922601 Bulk and RPC API support in translib (#16) 1d730df RFC7895 yang module library implementation (#15)

* [BFN] Updated platform APIs impl Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Extended BFN platform SFP APIs implementation * Update sfp.py * [BFN] Extended SFP platform plugin implementation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Extended Fans platform plugin implementation * [BFN] divided classes Fan and FanDrawer into 2 files * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API * Add get_presence() function and revised __get() function Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * [BFN] Updated PSU platform APIs impl Signed-off-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> * Added BFN PSU cache (#9) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Fans and Fantray platform APIs update (#7) * [BFN] Updated SFP platform APIs (#10) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [BFN] Updated platform API for thermal (#8) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "[BFN] Fans and Fantray platform APIs update (#7)" (#11) This reverts commit c62a733. * Add support health monitor system (#15) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * Update chassis.py * [BFN] Updated FANs and FAN Tray platform API (#14) * Fix fix_alignment (#17) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * [BFN] Improvement show environment (#16) * Added PSU temperature skip into platform.json (#18) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Do not skip psud on Newport Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] fix fan status from Not OK to Ok (#19) * [BFN] Updated SFP platform plugin (#13) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21) Signed-off-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com> * [barefoot] Tmp fix vendor_rev (#22) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * Fixed python issues in sonic_platform/fan_drawer.py Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Updated fan_drawer.py * Fixing trailing white spaces in fan_drawer.py * [BFN] Fix thrift for SFPs API Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [Newport] Thermal manager (#23) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue" This reverts commit 1e73127. * Removed 'controllable' options from platform.json to fix factory default config generation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Update thermal_manager.py * Migrated SFP plugin to sonic_xcvr API (#30) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> Co-authored-by: KostiantynYarovyiBf <kostiantynx.yarovyi@intel.com> Co-authored-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> Co-authored-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> Co-authored-by: Volodymyr Boiko <volodymyrx.boiko@intel.com> Co-authored-by: Petro Bratash <petrox.bratash@intel.com> Co-authored-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>

[sonic_platform]support install firmware

2c8e646

nazariig suggested changes Dec 11, 2019

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Show resolved Hide resolved

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

[component.py]Address comments

80ecdaa

nazariig suggested changes Dec 12, 2019

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

nazariig suggested changes Dec 12, 2019

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Show resolved Hide resolved

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

nazariig suggested changes Dec 12, 2019

View reviewed changes

[component.py]address comments

f73b20b

Stephen Sun added 4 commits December 13, 2019 14:44

[platform_api]add chassis.get_name, add exit code checking

b411566

[component.py]add return code check for subprocess handling

37b11ca

[component]update name: onie-fw-updated.sh

30a4ae7

the onie-fw-update has been postfixed with ".sh" after installed on the DUT.

[chassis]update the way to get the chassis name to using onie_platfor…

9477140

…m info

stephenxs closed this Dec 19, 2019

stephenxs pushed a commit that referenced this pull request Aug 8, 2020

[sonic-ztp] Update submodule (sonic-net#5120)

6b72dee

* src/sonic-ztp c959371...dd025bc (2): > Update all references to new 'sonic-installer' file name (#18) > Filter out non-printable characters read from syseeprom (#17)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sonic_platform]support install firmware #18

[sonic_platform]support install firmware #18

stephenxs commented Nov 21, 2019

nazariig Dec 11, 2019

stephenxs Dec 12, 2019

stephenxs Dec 12, 2019

stephenxs Dec 13, 2019

nazariig commented Dec 11, 2019

nazariig Dec 12, 2019

stephenxs Dec 12, 2019

stephenxs Dec 13, 2019

nazariig Dec 13, 2019

nazariig Dec 12, 2019

stephenxs Dec 13, 2019

nazariig Dec 13, 2019

stephenxs commented Dec 13, 2019

		@@ -60,12 +74,39 @@ def _get_command_result(self, cmdline):
		return result

[sonic_platform]support install firmware #18

[sonic_platform]support install firmware #18

Conversation

stephenxs commented Nov 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nazariig commented Dec 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephenxs commented Dec 13, 2019