Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isort version 5.0.x support #24

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Add isort version 5.0.x support #24

merged 1 commit into from
Jul 6, 2020

Conversation

Mystic-Mirage
Copy link
Contributor

This solves #23

Still compatible with isort <5 to support python 2.7 and 3.5

Changed behavior of isort_check_file to opposite to match check_file from isort

@Mystic-Mirage Mystic-Mirage mentioned this pull request Jul 4, 2020
Merged
1 task
@akaihola akaihola mentioned this pull request Jul 5, 2020
Closed
@stephrdev
Copy link
Owner

thanks for the PR, will try to merge and release asap.

@stephrdev stephrdev merged commit 6a42d3a into stephrdev:master Jul 6, 2020
@bnavigator bnavigator mentioned this pull request Jul 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaihola akaihola akaihola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mystic-Mirage @stephrdev @akaihola