Use CamelCase for gpio::Edge enum variants #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cf. discussion in stm32-rs/stm32f4xx-hal#250 |
This was referenced Jan 10, 2021
Piroro-hs
force-pushed
the
gpio-edge-camel-case
branch
from
e729ba9 to
7b70472
Compare
|
Looks like the rest of the ecosystem are starting to merge this, so I guess we'll follow through. I'll hold off on actually merging it until we have more pressing breaking changes to merge though. |
bors bot
added a commit
to stm32-rs/stm32h7xx-hal
that referenced
this pull request
Jan 31, 2021
179: Use CamelCase for gpio::Edge enum variants r=richardeoin a=Piroro-hs ref: [l4xx](stm32-rs/stm32l4xx-hal#187), [f1xx](stm32-rs/stm32f1xx-hal#303), [f4xx](stm32-rs/stm32f4xx-hal#250), [f7xx](stm32-rs/stm32f7xx-hal#111) Co-authored-by: Piroro-hs <Piroro-hs@users.noreply.github.com>
burrbull
approved these changes
Jul 14, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: h7xx, l4xx, f4xx, f7xx