Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CamelCase for gpio::Edge enum variants #250

Closed
wants to merge 1 commit into from
Closed

Use CamelCase for gpio::Edge enum variants #250

wants to merge 1 commit into from

Conversation

Piroro-hs
Copy link
Contributor

@Piroro-hs Piroro-hs commented Jan 10, 2021 •
edited
Loading

ref: h7xx, l4xx, f1xx, f7xx

@Piroro-hs Piroro-hs force-pushed the gpio-edge-camel-case branch from 6271c90 to 4de6eb3 Compare January 10, 2021 14:09
@therealprof
Copy link
Member

Thanks for your PR. I don't think we should apply it though since it will break all applications out there using this functionality without good reason.

@Piroro-hs
Copy link
Contributor Author

Piroro-hs commented Jan 10, 2021 •
edited
Loading

Thanks for fast reply!
I thought that it can be fixed for now as this and other stm32 HALs does not reached to v1.0.0.

@therealprof
Copy link
Member

Thanks for fast reply!
I thought that it can be fixed for now as this and other stm32 HALs does not reached to v1.0.0.

Well, yes and no. 😅 1.0 is just a label and the question is whether those crates will ever reach "1.0" since every change to the svd files or svd2rust have to be considered a breaking change and would have to result in an inflationary major version bumping... I'm not opposed to necessary breaking changes (to fix bugs or usability shortcomings) but this particular change seems to lack a good motive.

@therealprof therealprof mentioned this pull request Jan 10, 2021
Merged
This was referenced Jan 10, 2021
Merged
Merged
Merged
bors bot added a commit to stm32-rs/stm32h7xx-hal that referenced this pull request Jan 31, 2021
@bors @Piroro-hs
Merge #179
5471426 
179: Use CamelCase for gpio::Edge enum variants r=richardeoin a=Piroro-hs

ref: [l4xx](stm32-rs/stm32l4xx-hal#187), [f1xx](stm32-rs/stm32f1xx-hal#303), [f4xx](stm32-rs/stm32f4xx-hal#250), [f7xx](stm32-rs/stm32f7xx-hal#111)


Co-authored-by: Piroro-hs <Piroro-hs@users.noreply.github.com>
@burrbull
Copy link
Member

burrbull commented Jul 4, 2021

Rebase, please.

bors bot added a commit to stm32-rs/stm32f1xx-hal that referenced this pull request Jul 14, 2021
@bors @Piroro-hs
Merge #303
846e9c6 
303: Use CamelCase for gpio::Edge enum variants r=burrbull a=Piroro-hs

ref: [h7xx](stm32-rs/stm32h7xx-hal#179), [l4xx](stm32-rs/stm32l4xx-hal#187), [f4xx](stm32-rs/stm32f4xx-hal#250), [f7xx](stm32-rs/stm32f7xx-hal#111)


Co-authored-by: Piroro-hs <Piroro-hs@users.noreply.github.com>
@burrbull burrbull mentioned this pull request Jul 14, 2021
Merged
@burrbull burrbull closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piroro-hs @therealprof @burrbull