Rename Serial items #402
Merged
Rename Serial items #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreySmirnov81
force-pushed
the
temp
branch
from
975f5d0 to
ca76a46
Compare
|
@burrbull, what do you think? |
|
Don't have strict opinion on naming. So if you think it is better I'm not opposite. |
burrbull
approved these changes
Feb 18, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe do the following renaming?
wordlength_8 -> wordlength_8bits
wordlength_9 -> wordlength_9bits
(since there may be not only data bits but also parity)
WordLength::DataBits8 -> WordLength::Bits8
WordLength::DataBits9 -> WordLength::Bits9
And also add
Config::wordlength(mut self, wordlength: WordLength).