Updating smoltcp on DMA branch #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More features are added by the dev-dependency so that the examples build
168: Reduce smoltcp dependency features to a minimum r=hargoniX a=richardeoin Since [*Dependencies are resolved with the union of all features enabled on them*](https://doc.rust-lang.org/cargo/reference/resolver.html#features), it's good practice to remove unnecessary dependencies. More features are added by the dev-dependency so that the examples build Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com>
* remove clear_uif_bit() it was identical to clear_irq() * add urs_counter_only() method * dogfood struct methods when implementing traits
|
I think there's a reasonable change of breaking changes still, and also changes in |
|
That was unexpected bors. Actually I'd rather you didn't delete master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
masterback intodmaso that we can get the smoltcp updates intodmaas well.As an aside, it seems to me like we should probably merge
dmain to master - I'm fairly sure a lot of people are essentially treatingdmaasmasterto get access to DMA transfers right now. Curious to hear thoughts here