Avoid creating intermediate references to packed fields #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Such an intermediate reference is UB, even if it is never dereferenced. The previous code that created addresses / raw pointers via intermediate references will become a hard error in a future version of Rust. Use [core::ptr::addr_of](https://doc.rust-lang.org/core/ptr/macro.addr_of.html) instead. This commit increases the MSRV to 1.51.0
richardeoin
force-pushed
the
lints2021_2
branch
from
fdbf616
to
c10c266
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 2, 2021
225: Avoid creating intermediate references to packed fields r=richardeoin a=richardeoin Such an intermediate reference is UB, even if it is never dereferenced. The previous code that created addresses / raw pointers via intermediate references will become a hard error in a future version of Rust. Use [core::ptr::addr_of](https://doc.rust-lang.org/core/ptr/macro.addr_of.html) instead. This PR increases the MSRV to 1.51.0 Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com>
|
Canceled. |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such an intermediate reference is UB, even if it is never dereferenced. The previous code that created addresses / raw pointers via intermediate references will become a hard error in a future version of Rust. Use core::ptr::addr_of instead.
This PR increases the MSRV to 1.51.0