Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10.0 #233

Merged
merged 2 commits into from
Jul 21, 2021
Merged

v0.10.0 #233

merged 2 commits into from
Jul 21, 2021

Conversation

richardeoin
Copy link
Member

No description provided.

@hargoniX
Copy link
Member

hargoniX commented Jul 21, 2021

I'm guessing #172 would be the only PR that is left for this release? But it seems like the author has abandoned it quite some time ago so we might as well go for it.

It would be a nice thing if we would finally fix all these clippy lints from our CI though, they always clutter the diffs a ton.

@ryan-summers
Copy link
Member

It would be a nice thing if we would finally fix all these clippy lints from our CI though, they always clutter the diffs a ton.

+1 from me. We should elevate clippy warnings to errors and force them to be fixed through CI in the future. If you really don't want a check, you can reason why and add a #[cfg()] instead to disable the check at that point.

Other than that, the release sounds good to me. I've been working off master for quite some time without issue.

@hargoniX
Copy link
Member

If we don't want to tackle this in this PR I'd approve as well...do we?

@mlamoore
Copy link
Contributor

mlamoore commented Jul 21, 2021 via email

@richardeoin
Copy link
Member Author

I definitely agree with keeping the clippy warnings under control! #224 removed a few, and #225 will tackle some more. In fact, I only left #225 unmerged so that we could have one last release on the old MSRV, otherwise it's ready for review.

Anyhow I'll make the release now, thanks all!

@richardeoin richardeoin merged commit bcd1f0b into master Jul 21, 2021
@bors bors bot deleted the v0.10.0 branch July 21, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants