test(oas): reduce the amount of boilerplate #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
test/reduce-boilerplate-in-oas-tests
branch
from
1d772fa to
a4e1c24
Compare
P0lip
force-pushed
the
test/reduce-boilerplate-in-oas-tests
branch
from
73d723b to
72b8cf0
Compare
4 tasks
domagojk
reviewed
Jan 13, 2021
| import { isOpenApiv2, isOpenApiv3 } from '../../../../formats'; | ||
| import * as ruleset from '../../index.json'; | ||
|
|
||
| export async function loadRules(rules: (keyof typeof ruleset['rules'])[], opts?: IConstructorOpts): Promise<Spectral> { |
There was a problem hiding this comment.
Maybe call it createWithRules (or something similar) since it doesn't just load the rules?
Yeah, |
domagojk
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1470
Related to #1082
Checklist
Does this PR introduce a breaking change?