Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the test maintainance #1082

Closed
4 tasks
nulltoken opened this issue Apr 13, 2020 · 0 comments · Fixed by #1665
Closed
4 tasks

Reduce the test maintainance #1082

nulltoken opened this issue Apr 13, 2020 · 0 comments · Fixed by #1665
Assignees
Labels
chore tech-debt v6 Scheduled to be released in v6
Milestone

Comments

@nulltoken
Copy link
Contributor

nulltoken commented Apr 13, 2020

Chore summary
From #1079 (comment)

From @nulltoken:

Just off-topic thought: This current test set up compels us to duplicate tests and use two different libs to intercept fetch calls and, depending on the the scope, use 3 different suffixes for test files (jest, karma or void).
This makes contributing and reviewing a little bit harder than it should be.
I feel there might be a better way to do this.
Thoughts?

From @P0lip

@P0lip Just off-topic thought: This current test set up compels us to duplicate tests and use two different libs to intercept fetch calls and, depending on the the scope, use 3 different suffixes for test files (jest, karma or void).

Yeah, that is true.

I feel there might be a better way to do this.

We could simply drop nock and use fetch-mock everywhere, I believe.
Nock is pretty cool though as it's an actual server.

Tasks

  • Decrease reliance on built-in rulesets in tests - this makes it more challenging to update OAS (and possibly AsyncAPI) ruleset
  • Use fetch-mock everywhere
  • Find a way to avoid test duplication between node based and browser based testing (when dealing with window.fetch for instance)
  • Remove test duplicates as much as possible
@philsturgeon philsturgeon added this to the v6.0 milestone Apr 28, 2020
@philsturgeon philsturgeon added the breaking Pull requests that introduce a breaking change label Jul 9, 2020
@philsturgeon philsturgeon added tech-debt and removed breaking Pull requests that introduce a breaking change labels May 4, 2021
@P0lip P0lip added the v6 Scheduled to be released in v6 label May 11, 2021
@P0lip P0lip self-assigned this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore tech-debt v6 Scheduled to be released in v6
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants