Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(oas): use a rule tester #1665

Merged
merged 2 commits into from
Jun 10, 2021
Merged

test(oas): use a rule tester #1665

merged 2 commits into from
Jun 10, 2021

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jun 9, 2021

This is most the copy-paste of #1650 with added support for fs mocks to dedupe certain tests.
Closes #1082

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip changed the title test(oas): use rule tester test(oas): use a rule tester Jun 9, 2021
@P0lip P0lip force-pushed the test/oas-template branch 2 times, most recently from 9f8db5b to aa0ebde Compare June 10, 2021 10:28
@P0lip P0lip self-assigned this Jun 10, 2021
@P0lip P0lip force-pushed the test/oas-template branch from e31a87b to d27a01b Compare June 10, 2021 13:03
@P0lip P0lip marked this pull request as ready for review June 10, 2021 13:03
@P0lip P0lip merged commit a7d0342 into develop Jun 10, 2021
@P0lip P0lip deleted the test/oas-template branch June 10, 2021 13:10
@P0lip
Copy link
Contributor Author

P0lip commented Jun 10, 2021

I'm merging this as this doesn't involve any meaningful change anyway and the approach was validated in the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the test maintainance
1 participant