Skip to content

Commit

Permalink
fix: disable UCAN log expiration (#416)
Browse files Browse the repository at this point in the history
it looks like we set this bucket up to expire items - in retrospect I
think we should have created a separate bucket for the UCAN log because
this stream log store bucket was probably originally meant to store
streaming items temporarily

disable expiration for now, but uncomment with a note
  • Loading branch information
travis authored Sep 19, 2024
1 parent f2a18f2 commit 560329a
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions stacks/firehose-stack.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,13 @@ export function UcanFirehoseStack ({ stack, app }) {
cdk: {
bucket: {
...getBucketConfig('stream-log-store', app.stage),
lifecycleRules: [{
enabled: true,
expiration: Duration.days(90)
}]
lifecycleRules: [
// disable this for now - maybe we do want lifecycle rules eventually but we DEFINITELY don't want to expire these logs!
// {
// enabled: true,
// expiration: Duration.days(90)
// }
]
}
}
})
Expand Down

0 comments on commit 560329a

Please sign in to comment.