Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable UCAN log expiration #416

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

travis
Copy link
Member

@travis travis commented Aug 19, 2024

it looks like we set this bucket up to expire items - in retrospect I think we should have created a separate bucket for the UCAN log because this stream log store bucket was probably originally meant to store streaming items temporarily

disable expiration for now, but uncomment with a note

it looks like we set this bucket up to expire items - in retrospect I think we should have created a separate bucket for the UCAN log because this stream log store bucket was probably originally meant to store streaming items temporarily

disable expiration for now, but uncomment with a note
Copy link

seed-deploy bot commented Aug 19, 2024

View stack outputs

Copy link
Member

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travis travis merged commit 560329a into main Sep 19, 2024
3 checks passed
@travis travis deleted the fix/disable-ucan-log-expiration branch September 19, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants