Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement getCID methods on store and upload tables #225

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

travis
Copy link
Member

@travis travis commented Sep 13, 2023

this enables the new capability invocation handlers in storacha/w3up#918

this enables the new capability invocation handlers in storacha/w3up#918
@seed-deploy seed-deploy bot temporarily deployed to pr225 September 13, 2023 04:09 Inactive
@seed-deploy
Copy link

seed-deploy bot commented Sep 13, 2023

View stack outputs

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to call it something closer to what it's retrieving getCID to me says retrieve a CID. Is it metadata? You say "information" in the description - getInfo, stat?

@travis
Copy link
Member Author

travis commented Sep 18, 2023

oh yea - we actually switched to "inspect" in the capability name (storacha/w3up#918) - @alanshaw how would you feel about inspectCID ?

@alanshaw
Copy link
Member

Just inspect?

travis added a commit to storacha/w3up that referenced this pull request Sep 18, 2023
travis added a commit to storacha/w3up that referenced this pull request Sep 18, 2023
@travis
Copy link
Member Author

travis commented Sep 18, 2023

ok updated! I think the errors here may be due to some cleanup @vasco-santos did with the Kinesis streams - I think they should be safe to ignore. @alanshaw anything else blocking approval?

@travis travis merged commit dcaeac3 into main Sep 18, 2023
1 check passed
@travis travis deleted the feat/cid-lookup-capabilities branch September 18, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants