feat: implement admin/upload/inspect and admin/store/inspect capabilities
#918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementations of new capabilities proposed in storacha/specs#77
This will enable us to implement the invocation handlers for `root/get` and `shard/get`
including adding `/*` top level capabilities for both `root` and `shard`
This required a few more tweaks to the capabilities package types.
I've added test suites for both new namespaces and added a new `getCID` method to each of the `{Upload|Store}Table` interfaces, and updated the in-memory implementations of each.
this is strange because they don't seem to be necessary (and they aren't in Visual Studio!) but a cheeky typecast fixes them for now
Gozala
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
@travis I'm approving this as implementation of the spec looks good. That said I do think we need to iterate on the spec (sorry for not reviewing it sooner) to avoid taking up generic namespaces for system introspection capabilities.
Feel free to land as is and we can iterate on naming in followups, or we can align on naming and update this pr before landing.
travis
changed the title
root/get and shard/get capabilitiesadmin/upload/inspect and admin/store/inspect capabilities
|
No worries at all @Gozala! I've updated this for the latest version of the spec - I'll hold off on merging until I've spiked this out full-stack, so feel free to re-review or not - the latest updates are basically just name changes and restructuring the match, but couldn't hurt to have more eyes. |
travis
changed the title
admin/upload/inspect and admin/store/inspect capabilitiesadmin/upload/inspect and admin/store/inspect capabilities
it doesn't seem like we support Date types in Ucanto service return values?
This was referenced Sep 13, 2023
travis
pushed a commit
that referenced
this pull request
Sep 13, 2023
🤖 I have created a release *beep* *boop* --- ## [9.3.0](capabilities-v9.2.1...capabilities-v9.3.0) (2023-09-13) ### Features * implement `admin/upload/inspect` and `admin/store/inspect` capabilities ([#918](#918)) ([5616a12](5616a12)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
travis
added a commit
that referenced
this pull request
Sep 13, 2023
🤖 I have created a release *beep* *boop* --- ## [5.4.0](upload-api-v5.3.1...upload-api-v5.4.0) (2023-09-13) ### Features * implement `admin/upload/inspect` and `admin/store/inspect` capabilities ([#918](#918)) ([5616a12](5616a12)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
travis
added a commit
to storacha/w3infra
that referenced
this pull request
Sep 13, 2023
this enables the new capability invocation handlers in storacha/w3up#918
travis
added a commit
to storacha/w3infra
that referenced
this pull request
Sep 18, 2023
this enables the new capability invocation handlers in storacha/w3up#918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin/upload/inspectandadmin/store/inspectcapabilities specs#77getCIDmethod to each of the{Upload|Store}Tableinterfaces, and updated the in-memory implementations of each.admin/upload/inspectandadmin/store/inspectinvocation handlers