Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add indexer support #65

Closed
shilman opened this issue Jul 14, 2022 · 3 comments · Fixed by #69
Closed

Add indexer support #65

shilman opened this issue Jul 14, 2022 · 3 comments · Fixed by #69
Labels
enhancement New feature or request released This issue/pull request has been released.

Comments

@shilman
Copy link
Member

shilman commented Jul 14, 2022

Currently stories.svelte files are incompatible with:

To address this, we've added an "indexer" API to Storybook core for 7.0: storybookjs/storybook#18355

If addon-svelte-csf were to implement an indexer, it would solve the above problems, plus other future problems as we build more on top of the story index (which we will definitely do more of in core)
@shilman shilman added the enhancement New feature or request label Jul 14, 2022
@shilman shilman mentioned this issue Jul 14, 2022
Closed
3 tasks
@j3rem1e
Copy link
Contributor

j3rem1e commented Jul 14, 2022

I have a working implementation in a private branch. I have to add tests and check how I can merge this without loosing compatibility with v6

@shilman
Copy link
Member Author

shilman commented Jul 14, 2022

@j3rem1e that's wonderful news! It might make sense to release that change in an alpha rather than a full release. The indexer API is 7.0-alpha and might change between now and the final release. Specifically, we might update it to make watch mode possible in the test runner. cc @yannbf

@shilman shilman mentioned this issue Jul 14, 2022
Closed
@j3rem1e j3rem1e mentioned this issue Sep 4, 2022
Merged
@shilman
Copy link
Member Author

shilman commented Oct 27, 2022

🚀 Issue was released in v2.0.9 🚀

@shilman shilman added the released This issue/pull request has been released. label Oct 27, 2022
DanConwayDev added a commit to DanConwayDev/gitworkshop that referenced this issue Dec 5, 2023
@DanConwayDev
refactor: use svelte storybook format
73d0554 
replace plain typescript storybook format with svelte using
addon-svelte-csf

this requires running test-storybook with --json-index flag. see:
 - storybookjs/addon-svelte-csf#65
 - storybookjs/test-runner#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement a Svelte StoryIndexer storybookjs/addon-svelte-csf
2 participants
@shilman @j3rem1e