Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Add pluggable indexers #18355

Merged
merged 5 commits into from
May 31, 2022
Merged

Core: Add pluggable indexers #18355

merged 5 commits into from
May 31, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented May 30, 2022 •
edited
Loading

Issue: #18081

What I did

  • Add pluggable indexers API
  • Move MDX indexer to addon-docs

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented May 30, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 397e875. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@j3rem1e
Copy link
Contributor

j3rem1e commented May 30, 2022

Shouldn't this check be opened too ?

storybook/lib/core-server/src/utils/StoryIndexGenerator.ts

Line 56 in 4db554b

if (!['.js', '.jsx', '.ts', '.tsx', '.mdx'].includes(ext)) {

@shilman
Copy link
Member Author

shilman commented May 30, 2022

Good catch @j3rem1e! I updated it to allow for all file extensions 👍

tmeasday
tmeasday approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Should we drop readCsfOrMdx too?

@yannbf
Copy link
Member

yannbf commented May 30, 2022

@shilman could you take a look at the failures in CI?

No matching story indexer found for /tmp/storybook/examples/html-kitchen-sink/stories/__snapshots__/addon-a11y.stories.storyshot

@shilman shilman merged commit 4bd9fba into future/base May 31, 2022
@shilman shilman deleted the future/pluggable-indexers branch May 31, 2022 03:45
@shilman shilman mentioned this pull request Jun 6, 2022
Closed
@shilman shilman mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
api: addons core feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shilman @j3rem1e @yannbf @tmeasday @Hypnosphi