Skip to content

Commit

Permalink
Cleanup peerDependencies (#445)
Browse files Browse the repository at this point in the history
@storybook/source-loader doesn't need to be in peerDependencies because it's already in dependencies

@storybook/core-common and @storybook/node-logger can be just regular dependencies instead of peerDependencies since we don't need the user to add them to their package.json

~~@storybook/mdx1-csf doesn't need to be downloaded by all users. Users will use either @storybook/mdx1-csf or @storybook/mdx2-csf so move it to devDependencies so that users won't end up including it automatically~~
  • Loading branch information
benmccann authored Jul 15, 2022
1 parent ed2a70b commit ee69357
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
5 changes: 2 additions & 3 deletions packages/builder-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
"homepage": "https://github.com/storybookjs/builder-vite/#readme",
"dependencies": {
"@joshwooding/vite-plugin-react-docgen-typescript": "0.0.4",
"@storybook/core-common": "^6.4.3",
"@storybook/mdx1-csf": "^0.0.4",
"@storybook/node-logger": "^6.4.3",
"@storybook/source-loader": "^6.4.3",
"@vitejs/plugin-react": "^2.0.0",
"ast-types": "^0.14.2",
Expand All @@ -34,10 +36,7 @@
"vue-docgen-api": "^4.40.0"
},
"peerDependencies": {
"@storybook/core-common": ">=6.4.3",
"@storybook/mdx2-csf": "^0.0.3",
"@storybook/node-logger": ">=6.4.3",
"@storybook/source-loader": ">=6.4.3",
"vite": ">= 3.0.0"
},
"peerDependenciesMeta": {
Expand Down
9 changes: 4 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2857,8 +2857,10 @@ __metadata:
resolution: "@storybook/builder-vite@workspace:packages/builder-vite"
dependencies:
"@joshwooding/vite-plugin-react-docgen-typescript": 0.0.4
"@storybook/core-common": ^6.4.3
"@storybook/mdx1-csf": ^0.0.4
"@storybook/mdx2-csf": ^0.0.3
"@storybook/node-logger": ^6.4.3
"@storybook/source-loader": ^6.4.3
"@sveltejs/vite-plugin-svelte": ^1.0.0
"@types/express": ^4.17.13
Expand All @@ -2874,10 +2876,7 @@ __metadata:
sveltedoc-parser: ^4.2.1
vue-docgen-api: ^4.40.0
peerDependencies:
"@storybook/core-common": ">=6.4.3"
"@storybook/mdx2-csf": ^0.0.3
"@storybook/node-logger": ">=6.4.3"
"@storybook/source-loader": ">=6.4.3"
vite: ">= 3.0.0"
peerDependenciesMeta:
"@storybook/mdx2-csf":
Expand Down Expand Up @@ -3082,7 +3081,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/core-common@npm:6.5.9":
"@storybook/core-common@npm:6.5.9, @storybook/core-common@npm:^6.4.3":
version: 6.5.9
resolution: "@storybook/core-common@npm:6.5.9"
dependencies:
Expand Down Expand Up @@ -3403,7 +3402,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/node-logger@npm:6.5.9":
"@storybook/node-logger@npm:6.5.9, @storybook/node-logger@npm:^6.4.3":
version: 6.5.9
resolution: "@storybook/node-logger@npm:6.5.9"
dependencies:
Expand Down

0 comments on commit ee69357

Please sign in to comment.