Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup peerDependencies #445

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Cleanup peerDependencies #445

merged 3 commits into from
Jul 15, 2022

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Jul 14, 2022

@storybook/source-loader doesn't need to be in peerDependencies because it's already in dependencies

@storybook/core-common and @storybook/node-logger can be just regular dependencies instead of peerDependencies since we don't need the user to add them to their package.json

@storybook/mdx1-csf doesn't need to be downloaded by all users. Users will use either @storybook/mdx1-csf or @storybook/mdx2-csf so move it to devDependencies so that users won't end up including it automatically

Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. The only one I don't think we can move is @storybook/mdx1-csf. Since we require a particular version.

packages/builder-vite/package.json Outdated Show resolved Hide resolved
@IanVS IanVS merged commit ee69357 into storybookjs:main Jul 15, 2022
@benmccann benmccann deleted the peerDeps branch July 15, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants