Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon/docs Cannot read property 'modernInlineRender' of undefined #95

Closed
KaiSpencer opened this issue Sep 14, 2021 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@KaiSpencer
Copy link

KaiSpencer commented Sep 14, 2021

Unable to render Docs page.

Key Versions:
"@storybook/addon-docs": "^6.4.0-alpha.35",
"@storybook/addon-actions": "^6.4.0-alpha.35",
"@storybook/addon-essentials": "^6.4.0-alpha.35",
"@storybook/addon-links": "^6.4.0-alpha.35",
"@storybook/react": "^6.4.0-alpha.35",
"react": "^17.0.0",
"vite": "^2.5.7",
"storybook-builder-vite": "^0.0.12",

Screenshot 2021-09-14 at 15 23 57

@IanVS
Copy link
Member

IanVS commented Sep 14, 2021

This seems to have been added in storybookjs/storybook#15871. We'll need to spend some time to figure out how to handle it, I guess.

@IanVS IanVS added the bug Something isn't working label Sep 14, 2021
@shilman
Copy link
Member

shilman commented Sep 14, 2021

Yowza. cc @tmeasday

@tmeasday
Copy link
Member

@IanVS - storybookjs/storybook#16044

Might be a good idea to always set window.FEATURES, but in the meantime we don't assume it in other places so I shouldn't assume it there.

@tmeasday
Copy link
Member

Meanwhile we should absolutely discuss how to implement the equivalent of the new v7 store entry point in Vite: https://github.com/storybookjs/storybook/blob/next/lib/builder-webpack4/src/preview/virtualModuleModernEntry.js.handlebars

@IanVS
Copy link
Member

IanVS commented Sep 15, 2021

@KaiSpencer could you please update storybook to 6.4.0-alpha.36 and try again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants