Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Be careful in FEATURES check #16044

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

tmeasday
Copy link
Member

See storybookjs/builder-vite#95

Issue: FEATURES may not be set

@nx-cloud
Copy link

nx-cloud bot commented Sep 14, 2021

Nx Cloud Report

CI ran the following commands for commit 5d4e5d9. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if typescript would catch this.

@shilman shilman changed the title Be careful in FEATURES check Core: Be careful in FEATURES check Sep 15, 2021
@shilman shilman merged commit 443cdc1 into next Sep 15, 2021
@shilman shilman deleted the fix/vite-95-missing-features branch September 15, 2021 00:05
@shilman shilman added this to the 6.4 PRs milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants