Fix Link transition perf by specifying properties #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesuss
commented
Jun 6, 2019
| color: ${darken(0.07, color.secondary)}; | ||
| } | ||
| &:active { | ||
| transform: translate3d(0, 0, 0); | ||
| transform: translateY(0); |
There was a problem hiding this comment.
Also no need for translate3d as the animation looks nice already w/ the updated transition properties specified.
|
Nice! |
|
🚀 PR was released in v0.0.19 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transition: allcan lead to p bad performance and I noticed that some things can be a bit janky as I was importing this into the other app. Better to specify the specific properties you want to transition so the browser doesn't have to guess!