Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Link transition perf by specifying properties #8

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Fix Link transition perf by specifying properties #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/Link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@ import { color } from './shared/styles';

const linkStyles = css`
display: inline-block;
transition: all 150ms ease-out;
transition: transform 150ms ease-out, color 150ms ease-out;
text-decoration: none;

color: ${color.secondary};

&:hover,
&:focus {
cursor: pointer;
transform: translate3d(0, -1px, 0);
transform: translateY(-1px);
color: ${darken(0.07, color.secondary)};
}
&:active {
transform: translate3d(0, 0, 0);
transform: translateY(0);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also no need for translate3d as the animation looks nice already w/ the updated transition properties specified.

color: ${darken(0.1, color.secondary)};
}

Expand Down